Trouble compiling kvm.git

Trouble compiling kvm.git

[Balaji Rao]

Hi,

I had trouble compiling kvm.git.

  LD      drivers/scsi/built-in.o
drivers/scsi/mvsas.o: In function `sas_ata_init_host_and_port':
/kernels/git/kvm/include/scsi/sas_ata.h:50: multiple definition of `sas_ata_init_host_and_port'
drivers/scsi/libsas/built-in.o:/kernels/git/kvm/include/scsi/sas_ata.h:50: first defined here
drivers/scsi/mvsas.o: In function `sas_ata_task_abort':
/kernels/git/kvm/include/scsi/sas_ata.h:54: multiple definition of `sas_ata_task_abort'
drivers/scsi/libsas/built-in.o:/kernels/git/kvm/include/scsi/sas_ata.h:54: first defined here
make[2]: *** [drivers/scsi/built-in.o] Error 1
make[1]: *** [drivers/scsi] Error 2
make: *** [drivers] Error 2

git-bisect pointed me to the following commit.

commit 0eb9ddd82a5cb08f3622345e723d236eefa0039f
Author: Ke Wei <kewei@marvell.com>
Date:   Thu Mar 27 14:53:24 2008 +0800

    [SCSI] mvsas: fill in error info record and phy mode6 bits.
    
    and remove some unused members from struct.
    
    Signed-off-by: Ke Wei <kewei@marvell.com>
    Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>

-- 
regards,
Balaji Rao
Dept. of Mechanical Engineering,
National Institute of Technology Karnataka, India

Re: Trouble compiling kvm.git

[James Bottomley]

On Mon, 2008-04-07 at 20:37 +0530, Balaji Rao wrote:
> Hi,
> 
> I had trouble compiling kvm.git.
> 
>   LD      drivers/scsi/built-in.o
> drivers/scsi/mvsas.o: In function `sas_ata_init_host_and_port':
> /kernels/git/kvm/include/scsi/sas_ata.h:50: multiple definition of `sas_ata_init_host_and_port'
> drivers/scsi/libsas/built-in.o:/kernels/git/kvm/include/scsi/sas_ata.h:50: first defined here
> drivers/scsi/mvsas.o: In function `sas_ata_task_abort':
> /kernels/git/kvm/include/scsi/sas_ata.h:54: multiple definition of `sas_ata_task_abort'
> drivers/scsi/libsas/built-in.o:/kernels/git/kvm/include/scsi/sas_ata.h:54: first defined here
> make[2]: *** [drivers/scsi/built-in.o] Error 1
> make[1]: *** [drivers/scsi] Error 2
> make: *** [drivers] Error 2

Actually, the problem is a long standing one.  The fix is in scsi-misc:

http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=6bd758961524129d2ad0163001681ebc2c7809e4

The work around is to compile SCSI as a module or not include mvsas.

James

Re: Trouble compiling kvm.git

[Balaji Rao]

On Monday 07 April 2008 08:50:36 pm James Bottomley wrote:
> On Mon, 2008-04-07 at 20:37 +0530, Balaji Rao wrote:
> > Hi,
> > 
> > I had trouble compiling kvm.git.
> > 
> >   LD      drivers/scsi/built-in.o
> > drivers/scsi/mvsas.o: In function `sas_ata_init_host_and_port':
> > /kernels/git/kvm/include/scsi/sas_ata.h:50: multiple definition of `sas_ata_init_host_and_port'
> > drivers/scsi/libsas/built-in.o:/kernels/git/kvm/include/scsi/sas_ata.h:50: first defined here
> > drivers/scsi/mvsas.o: In function `sas_ata_task_abort':
> > /kernels/git/kvm/include/scsi/sas_ata.h:54: multiple definition of `sas_ata_task_abort'
> > drivers/scsi/libsas/built-in.o:/kernels/git/kvm/include/scsi/sas_ata.h:54: first defined here
> > make[2]: *** [drivers/scsi/built-in.o] Error 1
> > make[1]: *** [drivers/scsi] Error 2
> > make: *** [drivers] Error 2
> 
> Actually, the problem is a long standing one.  The fix is in scsi-misc:
> 
> http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=6bd758961524129d2ad0163001681ebc2c7809e4
> 
> The work around is to compile SCSI as a module or not include mvsas.
> 
OK, thanks. But surprisingly i discovered it only today, after I updated my kvm.git tree. :)

-- 
thanks and regards,
Balaji Rao
Dept. of Mechanical Engineering,
National Institute of Technology Karnataka, India