From: Matt Helsley <matthltc@us.ibm.com>
To: Paul Jackson <pj@sgi.com>
Cc: linux-kernel@vger.kernel.org,
containers@lists.linux-foundation.org, clg@fr.ibm.com,
pavel@ucw.cz, menage@google.com, torvalds@linux-foundation.org,
linux-pm@lists.linux-foundation.org
Subject: Re: [RFC][PATCH 5/5] Add a Signal Control Group Subsystem
Date: Wed, 30 Apr 2008 00:48:34 -0700 [thread overview]
Message-ID: <1209541714.6095.72.camel@localhost.localdomain> (raw)
In-Reply-To: <20080424143032.7e659522.pj@sgi.com>
On Thu, 2008-04-24 at 14:30 -0500, Paul Jackson wrote:
> > +static struct cftype kill_file = {
> > + .name = "kill",
>
> The name "kill" seems ambiguous to me. It suggests that any write
> will send some default signal (TERM or KILL?) to all tasks in the
> cgroup, rather like the 'killall' command.
>
> I'm guessing that more people, on seeing this file in a cgroup
> directory, will guess correctly what it does if it were named
> "signal" or "send_signal" or some such.
OK, I renamed it signal.send and replaced all uses of "kill" in the code
to indicate that we're actually sending a signal -- not "KILL"ing
things :).
Cheers,
-Matt
next prev parent reply other threads:[~2008-04-30 7:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-24 6:47 [RFC][PATCH 0/5] Container Freezer: Reuse Suspend Freezer Matt Helsley
2008-04-24 6:47 ` [RFC][PATCH 1/5] Container Freezer: Add TIF_FREEZE flag to all architectures Matt Helsley
2008-04-24 8:09 ` Pavel Machek
2008-04-24 6:47 ` [RFC][PATCH 2/5] Container Freezer: Make refrigerator always available Matt Helsley
2008-04-25 11:04 ` Pavel Machek
2008-04-25 12:07 ` Cedric Le Goater
2008-04-26 13:02 ` Rafael J. Wysocki
2008-04-26 23:32 ` [RFC][PATCH] Freezer: NOSIG flag (was: Re: [RFC][PATCH 2/5] Container Freezer: Make refrigerator always available) Rafael J. Wysocki
2008-04-30 9:08 ` [RFC][PATCH 2/5] Container Freezer: Make refrigerator always available Matt Helsley
2008-04-24 6:47 ` [RFC][PATCH 3/5] Container Freezer: Implement freezer cgroup subsystem Matt Helsley
2008-04-25 5:51 ` Paul Menage
2008-04-28 4:03 ` Serge E. Hallyn
2008-04-30 10:39 ` Matt Helsley
2008-04-30 21:28 ` Matt Helsley
2008-04-30 22:30 ` Matt Helsley
2008-04-24 6:48 ` [RFC][PATCH 4/5] Container Freezer: Skip frozen cgroups during power management resume Matt Helsley
2008-04-24 6:48 ` [RFC][PATCH 5/5] Add a Signal Control Group Subsystem Matt Helsley
2008-04-24 19:30 ` Paul Jackson
2008-04-30 7:48 ` Matt Helsley [this message]
2008-04-30 8:18 ` Paul Jackson
2008-04-25 6:01 ` Paul Menage
2008-04-30 8:29 ` Matt Helsley
2008-04-25 11:41 ` Cedric Le Goater
2008-04-30 18:44 ` Matt Helsley
[not found] <20080423142517.062433911@us.ibm.com>
[not found] ` <20080423142518.703428301@us.ibm.com>
2008-04-23 15:17 ` [RFC PATCH " Cedric Le Goater
2008-04-23 15:37 ` Paul Menage
2008-04-24 7:00 ` Matt Helsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209541714.6095.72.camel@localhost.localdomain \
--to=matthltc@us.ibm.com \
--cc=clg@fr.ibm.com \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=menage@google.com \
--cc=pavel@ucw.cz \
--cc=pj@sgi.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome