From: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
To: Shrikanth Hegde <sshegde@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Madhavan Srinivasan <maddy@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/32: Use HAVE_PREEMPT_DYNAMIC_CALL instead of HAVE_PREEMPT_DYNAMIC_KEY
Date: Mon, 16 Nov 2026 16:19:01 +0100 [thread overview]
Message-ID: <120f301f-5359-4f56-8b21-87ef6470ffa4@kernel.org> (raw)
In-Reply-To: <763622c4-d2fc-4e84-8474-fdd72a64b5e6@linux.ibm.com>
Le 19/06/2026 à 14:32, Shrikanth Hegde a écrit :
> Hi Christophe.
>
> On 6/19/26 4:28 PM, Christophe Leroy (CS GROUP) wrote:
>> powerpc/32 has HAVE_STATIC_CALL_INLINE, so
>> HAVE_PREEMPT_DYNAMIC_CALL has to be selected instead of
>> HAVE_PREEMPT_DYNAMIC_KEY for less overhead.
>>
>
> Do you have any way to quantify this overhead?
>
>
>> Fixes: 6ad7751537e8 ("powerpc: enable dynamic preemption")
>> Signed-off-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>
Finally HAVE_PREEMPT_DYNAMIC_CALL was removed by commit 5b9a28eeed37
("sched: dynamic: Remove HAVE_PREEMPT_DYNAMIC_{CALL,KEY}").
So droping this patch.
>> ---
>> arch/powerpc/Kconfig | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
>> index 81642206f7de..7475907cef5b 100644
>> --- a/arch/powerpc/Kconfig
>> +++ b/arch/powerpc/Kconfig
>> @@ -281,7 +281,8 @@ config PPC
>> select HAVE_PERF_EVENTS_NMI if PPC64
>> select HAVE_PERF_REGS
>> select HAVE_PERF_USER_STACK_DUMP
>> - select HAVE_PREEMPT_DYNAMIC_KEY
>> + select HAVE_PREEMPT_DYNAMIC_CALL if PPC32
>> + select HAVE_PREEMPT_DYNAMIC_KEY if PPC64
>> select HAVE_RETHOOK if KPROBES
>> select HAVE_REGS_AND_STACK_ACCESS_API
>> select HAVE_RELIABLE_STACKTRACE
>
> Patch per se, looks good to me.
>
> Reviewed-by: Shrikanth Hegde <sshegde@linux.ibm.com>
prev parent reply other threads:[~2026-11-16 15:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-19 10:58 Christophe Leroy (CS GROUP)
2026-06-19 12:32 ` Shrikanth Hegde
2026-11-16 15:19 ` Christophe Leroy (CS GROUP) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=120f301f-5359-4f56-8b21-87ef6470ffa4@kernel.org \
--to=chleroy@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=sshegde@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®