* [PATCH] powerpc/32: Use HAVE_PREEMPT_DYNAMIC_CALL instead of HAVE_PREEMPT_DYNAMIC_KEY
@ 2026-06-19 10:58 Christophe Leroy (CS GROUP)
2026-06-19 12:32 ` Shrikanth Hegde
0 siblings, 1 reply; 3+ messages in thread
From: Christophe Leroy (CS GROUP) @ 2026-06-19 10:58 UTC (permalink / raw)
To: Shrikanth Hegde, Michael Ellerman, Nicholas Piggin, Madhavan Srinivasan
Cc: Christophe Leroy (CS GROUP), linux-kernel, linuxppc-dev
powerpc/32 has HAVE_STATIC_CALL_INLINE, so
HAVE_PREEMPT_DYNAMIC_CALL has to be selected instead of
HAVE_PREEMPT_DYNAMIC_KEY for less overhead.
Fixes: 6ad7751537e8 ("powerpc: enable dynamic preemption")
Signed-off-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>
---
arch/powerpc/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 81642206f7de..7475907cef5b 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -281,7 +281,8 @@ config PPC
select HAVE_PERF_EVENTS_NMI if PPC64
select HAVE_PERF_REGS
select HAVE_PERF_USER_STACK_DUMP
- select HAVE_PREEMPT_DYNAMIC_KEY
+ select HAVE_PREEMPT_DYNAMIC_CALL if PPC32
+ select HAVE_PREEMPT_DYNAMIC_KEY if PPC64
select HAVE_RETHOOK if KPROBES
select HAVE_REGS_AND_STACK_ACCESS_API
select HAVE_RELIABLE_STACKTRACE
--
2.54.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/32: Use HAVE_PREEMPT_DYNAMIC_CALL instead of HAVE_PREEMPT_DYNAMIC_KEY
2026-06-19 10:58 [PATCH] powerpc/32: Use HAVE_PREEMPT_DYNAMIC_CALL instead of HAVE_PREEMPT_DYNAMIC_KEY Christophe Leroy (CS GROUP)
@ 2026-06-19 12:32 ` Shrikanth Hegde
2026-11-16 15:19 ` Christophe Leroy (CS GROUP)
0 siblings, 1 reply; 3+ messages in thread
From: Shrikanth Hegde @ 2026-06-19 12:32 UTC (permalink / raw)
To: Christophe Leroy (CS GROUP),
Michael Ellerman, Nicholas Piggin, Madhavan Srinivasan
Cc: linux-kernel, linuxppc-dev
Hi Christophe.
On 6/19/26 4:28 PM, Christophe Leroy (CS GROUP) wrote:
> powerpc/32 has HAVE_STATIC_CALL_INLINE, so
> HAVE_PREEMPT_DYNAMIC_CALL has to be selected instead of
> HAVE_PREEMPT_DYNAMIC_KEY for less overhead.
>
Do you have any way to quantify this overhead?
> Fixes: 6ad7751537e8 ("powerpc: enable dynamic preemption")
> Signed-off-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>
> ---
> arch/powerpc/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index 81642206f7de..7475907cef5b 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -281,7 +281,8 @@ config PPC
> select HAVE_PERF_EVENTS_NMI if PPC64
> select HAVE_PERF_REGS
> select HAVE_PERF_USER_STACK_DUMP
> - select HAVE_PREEMPT_DYNAMIC_KEY
> + select HAVE_PREEMPT_DYNAMIC_CALL if PPC32
> + select HAVE_PREEMPT_DYNAMIC_KEY if PPC64
> select HAVE_RETHOOK if KPROBES
> select HAVE_REGS_AND_STACK_ACCESS_API
> select HAVE_RELIABLE_STACKTRACE
Patch per se, looks good to me.
Reviewed-by: Shrikanth Hegde <sshegde@linux.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/32: Use HAVE_PREEMPT_DYNAMIC_CALL instead of HAVE_PREEMPT_DYNAMIC_KEY
2026-06-19 12:32 ` Shrikanth Hegde
@ 2026-11-16 15:19 ` Christophe Leroy (CS GROUP)
0 siblings, 0 replies; 3+ messages in thread
From: Christophe Leroy (CS GROUP) @ 2026-11-16 15:19 UTC (permalink / raw)
To: Shrikanth Hegde, Michael Ellerman, Nicholas Piggin, Madhavan Srinivasan
Cc: linux-kernel, linuxppc-dev
Le 19/06/2026 à 14:32, Shrikanth Hegde a écrit :
> Hi Christophe.
>
> On 6/19/26 4:28 PM, Christophe Leroy (CS GROUP) wrote:
>> powerpc/32 has HAVE_STATIC_CALL_INLINE, so
>> HAVE_PREEMPT_DYNAMIC_CALL has to be selected instead of
>> HAVE_PREEMPT_DYNAMIC_KEY for less overhead.
>>
>
> Do you have any way to quantify this overhead?
>
>
>> Fixes: 6ad7751537e8 ("powerpc: enable dynamic preemption")
>> Signed-off-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>
Finally HAVE_PREEMPT_DYNAMIC_CALL was removed by commit 5b9a28eeed37
("sched: dynamic: Remove HAVE_PREEMPT_DYNAMIC_{CALL,KEY}").
So droping this patch.
>> ---
>> arch/powerpc/Kconfig | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
>> index 81642206f7de..7475907cef5b 100644
>> --- a/arch/powerpc/Kconfig
>> +++ b/arch/powerpc/Kconfig
>> @@ -281,7 +281,8 @@ config PPC
>> select HAVE_PERF_EVENTS_NMI if PPC64
>> select HAVE_PERF_REGS
>> select HAVE_PERF_USER_STACK_DUMP
>> - select HAVE_PREEMPT_DYNAMIC_KEY
>> + select HAVE_PREEMPT_DYNAMIC_CALL if PPC32
>> + select HAVE_PREEMPT_DYNAMIC_KEY if PPC64
>> select HAVE_RETHOOK if KPROBES
>> select HAVE_REGS_AND_STACK_ACCESS_API
>> select HAVE_RELIABLE_STACKTRACE
>
> Patch per se, looks good to me.
>
> Reviewed-by: Shrikanth Hegde <sshegde@linux.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-16 15:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-19 10:58 [PATCH] powerpc/32: Use HAVE_PREEMPT_DYNAMIC_CALL instead of HAVE_PREEMPT_DYNAMIC_KEY Christophe Leroy (CS GROUP)
2026-06-19 12:32 ` Shrikanth Hegde
2026-11-16 15:19 ` Christophe Leroy (CS GROUP)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®