mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] sisusbvga: Fix oops on disconnect.
@ 2008-06-18 16:47 Will Newton
  0 siblings, 0 replies; 3+ messages in thread
From: Will Newton @ 2008-06-18 16:47 UTC (permalink / raw)
  To: linux-kernel; +Cc: linux-usb, Will Newton

Remove the message printed with dev_info on disconnect after sisusb_dev has
potentially been zeroed by sisusb_delete. The message does not provide
any extra information over that which the USB subsystem prints as standard
so just kill it.

Signed-off-by: Will Newton <will.newton@gmail.com>
---
 drivers/usb/misc/sisusbvga/sisusb.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/misc/sisusbvga/sisusb.c b/drivers/usb/misc/sisusbvga/sisusb.c
index cb7fa0e..33182f4 100644
--- a/drivers/usb/misc/sisusbvga/sisusb.c
+++ b/drivers/usb/misc/sisusbvga/sisusb.c
@@ -3264,8 +3264,6 @@ static void sisusb_disconnect(struct usb_interface *intf)
 
 	/* decrement our usage count */
 	kref_put(&sisusb->kref, sisusb_delete);
-
-	dev_info(&sisusb->sisusb_dev->dev, "Disconnected\n");
 }
 
 static struct usb_device_id sisusb_table [] = {
-- 
1.5.5.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] sisusbvga: Fix oops on disconnect.
@ 2008-06-27 12:08 Will Newton
  0 siblings, 0 replies; 3+ messages in thread
From: Will Newton @ 2008-06-27 12:08 UTC (permalink / raw)
  To: linux-kernel; +Cc: linux-usb, felipe.lima, gregkh, Will Newton

From: Will Newton <will.newton@gmail.com>

Remove dev_info call on disconnect. The sisusb_dev pointer may have been
set to zero by sisusb_delete at this point causing an oops.

The message does not provide any extra information over the standard USB
subsystem output so removing it does not affect functionality.

Signed-off-by: Will Newton <will.newton@gmail.com>
---
 drivers/usb/misc/sisusbvga/sisusb.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/misc/sisusbvga/sisusb.c b/drivers/usb/misc/sisusbvga/sisusb.c
index cb7fa0e..33182f4 100644
--- a/drivers/usb/misc/sisusbvga/sisusb.c
+++ b/drivers/usb/misc/sisusbvga/sisusb.c
@@ -3264,8 +3264,6 @@ static void sisusb_disconnect(struct usb_interface *intf)
 
 	/* decrement our usage count */
 	kref_put(&sisusb->kref, sisusb_delete);
-
-	dev_info(&sisusb->sisusb_dev->dev, "Disconnected\n");
 }
 
 static struct usb_device_id sisusb_table [] = {
-- 
1.5.5.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] sisusbvga: Fix oops on disconnect.
@ 2008-06-18 16:59 Will Newton
  0 siblings, 0 replies; 3+ messages in thread
From: Will Newton @ 2008-06-18 16:59 UTC (permalink / raw)
  To: linux-kernel; +Cc: linux-usb, Will Newton

From: Will Newton <will.newton@gmail.com>

Remove the message printed with dev_info on disconnect after sisusb_dev has
potentially been zeroed by sisusb_delete. The message does not provide
any extra information over that which the USB subsystem prints as standard
so just kill it.

Signed-off-by: Will Newton <will.newton@gmail.com>
---
 drivers/usb/misc/sisusbvga/sisusb.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/misc/sisusbvga/sisusb.c b/drivers/usb/misc/sisusbvga/sisusb.c
index cb7fa0e..33182f4 100644
--- a/drivers/usb/misc/sisusbvga/sisusb.c
+++ b/drivers/usb/misc/sisusbvga/sisusb.c
@@ -3264,8 +3264,6 @@ static void sisusb_disconnect(struct usb_interface *intf)
 
 	/* decrement our usage count */
 	kref_put(&sisusb->kref, sisusb_delete);
-
-	dev_info(&sisusb->sisusb_dev->dev, "Disconnected\n");
 }
 
 static struct usb_device_id sisusb_table [] = {
-- 
1.5.5.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-06-27 12:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-06-18 16:47 [PATCH] sisusbvga: Fix oops on disconnect Will Newton
2008-06-18 16:59 Will Newton
2008-06-27 12:08 Will Newton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®