mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: hermann pitton <hermann-pitton@arcor.de>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Greg KH <greg@kroah.com>,
	v4l-dvb-maintainer@linuxtv.org, linux-usb@vger.kernel.org,
	dean@sensoray.com, video4linux-list@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [v4l-dvb-maintainer] [PATCH] add Sensoray 2255 v4l driver
Date: Sun, 29 Jun 2008 04:05:30 +0200	[thread overview]
Message-ID: <1214705130.2639.3.camel@pc10.localdom.local> (raw)
In-Reply-To: <20080628214335.40185450@gaivota>


Am Samstag, den 28.06.2008, 21:43 -0300 schrieb Mauro Carvalho Chehab:
> Hi Hermann,
> 
> On Sun, 29 Jun 2008 00:08:34 +0200
> hermann pitton <hermann-pitton@arcor.de> wrote:
> 
> 
> > On an attempt to get recent drivers on a FC8 x86_64 machine to watch
> > Glastonbury music festival on BBC HD DVB-S with the saa714 driver on an
> > recently updated 2.6.25 FC kernel it also fails to compile on some
> > strlcpy attempt. Same with a 2.6.24 on the mail machine here.
> > 
> >   CC [M]  /mnt/xfer/mercurial/v4l-dvb-head/v4l-dvb/v4l/quickcam_messenger.o
> >   CC [M]  /mnt/xfer/mercurial/v4l-dvb-head/v4l-dvb/v4l/s2255drv.o
> > /mnt/xfer/mercurial/v4l-dvb-head/v4l-dvb/v4l/s2255drv.c: In function 'vidioc_querycap':
> > /mnt/xfer/mercurial/v4l-dvb-head/v4l-dvb/v4l/s2255drv.c:809: error: implicit declaration of function 'dev_name'
> > /mnt/xfer/mercurial/v4l-dvb-head/v4l-dvb/v4l/s2255drv.c:809: warning: passing argument 2 of 'strlcpy' makes pointer from integer without a cast
> 
> The code is not backward compatible. It works only with 2.6.27-rc.
> 
> I'll add the macro ballow at compat.h to allow its out of tree compilation:
> 
> #define dev_name(dev)  ((dev)->bus_id)
> 
> This simple macro worked fine with 2.6.25.6.
> 
> Cheers,
> Mauro

Seems we had some crossed and delayed mails all over it.

I'll continue to cry, whenever it hurts.

Cheers,
Hermann



      parent reply	other threads:[~2008-06-29  2:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-26 23:15 Greg KH
2008-06-27 10:58 ` Oliver Neukum
2008-06-27 13:00 ` Mauro Carvalho Chehab
2008-06-28 11:31 ` Mauro Carvalho Chehab
2008-06-28 22:08   ` [v4l-dvb-maintainer] " hermann pitton
2008-06-29  0:43     ` Mauro Carvalho Chehab
2008-06-29  0:48       ` Mauro Carvalho Chehab
2008-06-29  1:01         ` hermann pitton
2008-06-29  2:05       ` hermann pitton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1214705130.2639.3.camel@pc10.localdom.local \
    --to=hermann-pitton@arcor.de \
    --cc=dean@sensoray.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=v4l-dvb-maintainer@linuxtv.org \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®