Re: [v4l-dvb-maintainer] [PATCH] add Sensoray 2255 v4l driver

[Mauro Carvalho Chehab <mchehab@infradead.org>]

Hi Hermann,

On Sun, 29 Jun 2008 00:08:34 +0200
hermann pitton <hermann-pitton@arcor.de> wrote:


> On an attempt to get recent drivers on a FC8 x86_64 machine to watch
> Glastonbury music festival on BBC HD DVB-S with the saa714 driver on an
> recently updated 2.6.25 FC kernel it also fails to compile on some
> strlcpy attempt. Same with a 2.6.24 on the mail machine here.
> 
>   CC [M]  /mnt/xfer/mercurial/v4l-dvb-head/v4l-dvb/v4l/quickcam_messenger.o
>   CC [M]  /mnt/xfer/mercurial/v4l-dvb-head/v4l-dvb/v4l/s2255drv.o
> /mnt/xfer/mercurial/v4l-dvb-head/v4l-dvb/v4l/s2255drv.c: In function 'vidioc_querycap':
> /mnt/xfer/mercurial/v4l-dvb-head/v4l-dvb/v4l/s2255drv.c:809: error: implicit declaration of function 'dev_name'
> /mnt/xfer/mercurial/v4l-dvb-head/v4l-dvb/v4l/s2255drv.c:809: warning: passing argument 2 of 'strlcpy' makes pointer from integer without a cast

The code is not backward compatible. It works only with 2.6.27-rc.

I'll add the macro ballow at compat.h to allow its out of tree compilation:

#define dev_name(dev)  ((dev)->bus_id)

This simple macro worked fine with 2.6.25.6.

Cheers,
Mauro