mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: "Chas Williams (CONTRACTOR)" <chas@cmf.nrl.navy.mil>
Cc: netdev@vger.kernel.org, linux-atm-general@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [Linux-ATM-General] [PATCH] firmware: convert Ambassador ATM driver to request_firmware()
Date: Mon, 30 Jun 2008 10:34:33 +0100	[thread overview]
Message-ID: <1214818473.10393.337.camel@pmac.infradead.org> (raw)
In-Reply-To: <200806051606.m55G6OTP029329@cmf.nrl.navy.mil>

On Thu, 2008-06-05 at 12:06 -0400, Chas Williams (CONTRACTOR) wrote:
> yes, it is troubling.  along the same lines, this patch removes the
> pca200e/sba200e firmware from the kernel.  the firmware will be in the
> next release of the userspace atm tools.  i could move the ambassador
> firmware there as well if you would like.

Sorry for dropping this; I'll let it go through the net tree now it's
there.

A couple of comments though... it looks like you forgot to add
MODULE_FIRMWARE(). And shouldn't 'fw_data' in
fore200e_load_and_start_firmware() be a (__le32 *) not a (u32 *)?

-- 
dwmw2


  parent reply	other threads:[~2008-06-30  9:34 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-05 12:07 David Woodhouse
2008-06-05 16:06 ` Chas Williams (CONTRACTOR)
2008-06-05 18:13   ` David Woodhouse
2008-06-05 18:20     ` Chas Williams (CONTRACTOR)
2008-06-05 18:28       ` David Woodhouse
2008-06-06 16:06         ` Chas Williams (CONTRACTOR)
2008-06-30  9:34   ` David Woodhouse [this message]
2008-06-30 12:50     ` [Linux-ATM-General] " Chas Williams (CONTRACTOR)
2008-06-30 12:59     ` Chas Williams (CONTRACTOR)
2008-06-30 13:09       ` David Woodhouse
2008-06-30 13:15         ` Chas Williams (CONTRACTOR)
2008-06-30 13:21           ` David Woodhouse
2008-06-30 13:59             ` Chas Williams (CONTRACTOR)
2008-06-30 14:54               ` David Woodhouse
2008-06-30 16:10                 ` Chas Williams (CONTRACTOR)
2008-06-30 19:18                   ` David Woodhouse
2008-07-01 12:55                     ` Chas Williams (CONTRACTOR)
2008-07-01 13:06                       ` David Woodhouse
2008-07-01 16:17                         ` Chas Williams (CONTRACTOR)
2008-07-09 20:37                     ` Chas Williams (CONTRACTOR)
2008-07-24  3:29                       ` David Miller
2008-06-30 19:46                   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1214818473.10393.337.camel@pmac.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=chas@cmf.nrl.navy.mil \
    --cc=linux-atm-general@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®