From: David Woodhouse <dwmw2@infradead.org>
To: "Chas Williams (CONTRACTOR)" <chas@cmf.nrl.navy.mil>
Cc: netdev@vger.kernel.org, linux-atm-general@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [Linux-ATM-General] [PATCH] firmware: convert Ambassador ATM driver to request_firmware()
Date: Mon, 30 Jun 2008 20:18:12 +0100 [thread overview]
Message-ID: <1214853492.10393.350.camel@pmac.infradead.org> (raw)
In-Reply-To: <200806301610.m5UGAlqr025302@cmf.nrl.navy.mil>
On Mon, 2008-06-30 at 12:10 -0400, Chas Williams (CONTRACTOR) wrote:
> In message <1214837678.10393.345.camel@pmac.infradead.org>,David Woodhouse writ
> es:
> >> i removed the #ifdef's from around MODULE_LICENSE(). there shouldnt
> >> be any need for #ifdef's around MODULE_FIRMWARE() either.
> >
> >Unless you put #ifdef CONFIG_SBUS around the
> >MODULE_FIRMWARE("sba200e_ecd.bin") you will be requesting that firmware
> >even on non-sbus machines. Likewise little-endian vs. big-endian on PCI.
>
> does it? i was under the impression that MODULE_FIRMWARE() just
> provides a hint that modinfo can read. request_firmware() still
> the requestor for the firmware image.
True. But if you were to put the driver into an initrd, for example,
then the tools would pick out all three firmwares to include in the
initrd too. Given that we _do_ know at runtime that we'll need a maximum
of two of the three, it makes sense to list only the ones we might use.
--
dwmw2
next prev parent reply other threads:[~2008-06-30 19:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-05 12:07 David Woodhouse
2008-06-05 16:06 ` Chas Williams (CONTRACTOR)
2008-06-05 18:13 ` David Woodhouse
2008-06-05 18:20 ` Chas Williams (CONTRACTOR)
2008-06-05 18:28 ` David Woodhouse
2008-06-06 16:06 ` Chas Williams (CONTRACTOR)
2008-06-30 9:34 ` [Linux-ATM-General] " David Woodhouse
2008-06-30 12:50 ` Chas Williams (CONTRACTOR)
2008-06-30 12:59 ` Chas Williams (CONTRACTOR)
2008-06-30 13:09 ` David Woodhouse
2008-06-30 13:15 ` Chas Williams (CONTRACTOR)
2008-06-30 13:21 ` David Woodhouse
2008-06-30 13:59 ` Chas Williams (CONTRACTOR)
2008-06-30 14:54 ` David Woodhouse
2008-06-30 16:10 ` Chas Williams (CONTRACTOR)
2008-06-30 19:18 ` David Woodhouse [this message]
2008-07-01 12:55 ` Chas Williams (CONTRACTOR)
2008-07-01 13:06 ` David Woodhouse
2008-07-01 16:17 ` Chas Williams (CONTRACTOR)
2008-07-09 20:37 ` Chas Williams (CONTRACTOR)
2008-07-24 3:29 ` David Miller
2008-06-30 19:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1214853492.10393.350.camel@pmac.infradead.org \
--to=dwmw2@infradead.org \
--cc=chas@cmf.nrl.navy.mil \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®