mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jaswinder Singh <jaswinder@infradead.org>
To: Fredrik Noring <noring@nocrew.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	David Woodhouse <dwmw2@infradead.org>,
	kernelnewbies <kernelnewbies@nl.linux.org>,
	kernel-janitors <kernel-janitors@vger.kernel.org>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	lars@nocrew.org, tomas@nocrew.org
Subject: Re: [PATCH] dsp56k: use request_firmware
Date: Sun, 06 Jul 2008 20:43:44 +0530	[thread overview]
Message-ID: <1215357224.2817.2.camel@jaswinder.satnam> (raw)
In-Reply-To: <A3D470E0-953E-40D6-BF5A-D06B76451154@nocrew.org>

Hello Fredrik,

On Sun, 2008-07-06 at 15:36 +0200, Fredrik Noring wrote:
> Hi Jaswinder,
> 
> 5 jul 2008 kl. 12.24 skrev Jaswinder Singh:
> > +	for (i = 0; i < fw->size; i + 3) {
> 
> Are you sure about "i + 3" in this loop? Isn't GCC complaining,  
> something like "statement with no effect"?
> 

Fixed, Thanks.

> > +Driver: ATARI_DSP56K - Atari DSP56k support
> > +
> > +File: dsp56k/bootstap.bin
> > +
> > +Licence: Unknown
> > +
> > +Found in hex form in kernel source.
> 
> I wrote this DSP56k assembler code in 1995. It's a trivial copy loop  
> that loads the main DSP program into memory. Please consider it GPL  
> like the driver code it came from.
> 
> A disassembler would easily recreate the original ~50 lines of  
> assembler source code, in case you'd like to assemble it with the rest  
> of kernel. :)
> 

Fixed.

Updated patch :
http://git.infradead.org/users/jaswinder/firm-jsr-2.6.git?a=commitdiff;h=4f5b8828113ea857a7b590b7dbb8a5ee78103de4

Thanks for you comments.

Thank you,

Jaswinder Singh.


  reply	other threads:[~2008-07-06 15:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-05 10:24 Jaswinder Singh
2008-07-06 13:36 ` Fredrik Noring
2008-07-06 15:13   ` Jaswinder Singh [this message]
2008-07-06 15:36     ` Fredrik Noring
2008-07-06 15:38       ` Jaswinder Singh
2008-07-06 16:54         ` David Woodhouse
2008-07-06 18:29           ` Fredrik Noring
2008-07-09 13:05             ` David Woodhouse
2008-07-10  7:38               ` Fredrik Noring
2008-07-10  8:53                 ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1215357224.2817.2.camel@jaswinder.satnam \
    --to=jaswinder@infradead.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=dwmw2@infradead.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kernelnewbies@nl.linux.org \
    --cc=lars@nocrew.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=noring@nocrew.org \
    --cc=tomas@nocrew.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®