mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Fredrik Noring <noring@nocrew.org>
Cc: "Jaswinder Singh" <jaswinder@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	kernelnewbies <kernelnewbies@nl.linux.org>,
	kernel-janitors <kernel-janitors@vger.kernel.org>,
	"Alan Cox" <alan@lxorguk.ukuu.org.uk>,
	"Lars Brinkhoff" <lars@nocrew.org>,
	"Tomas Skäre" <tomas@nocrew.org>
Subject: Re: [PATCH] dsp56k: use request_firmware
Date: Wed, 09 Jul 2008 14:05:50 +0100	[thread overview]
Message-ID: <1215608750.11567.177.camel@pmac.infradead.org> (raw)
In-Reply-To: <35647D7D-85D1-4308-B3A1-63CDCC3F14F7@nocrew.org>

On Sun, 2008-07-06 at 20:29 +0200, Fredrik Noring wrote:
> That's right. Sorry I was unclear. However, after some digging on  
> floppy backups from the past, I've found a DSP56k loader routine  
> that's probably close if not identical to the assembled version  
> included with the kernel. Please see below. A disassembly would verify
> this, but at least it gives you an idea of the inner workings.

It is in fact identical. Disassembly with the tools found on sourceforge
was fun, since they have endianness bugs, don't recognise the 'JMP'
which was the first instruction, and need each 3-byte instruction in the
binary to be prefixed with a zero byte to make it 4 bytes. But after
sorting that out and going through it instruction by instruction, it
really does seem to match. Thanks very much for digging it out.

When you say 'GPL like the driver it came from', actually the driver
doesn't specify any version of the GPL but does refer to the top-level
COPYING file. So we'll take that to mean 'GPLv2 and not later', like the
majority of the kernel. OK?

-- 
dwmw2


  reply	other threads:[~2008-07-09 13:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-05 10:24 Jaswinder Singh
2008-07-06 13:36 ` Fredrik Noring
2008-07-06 15:13   ` Jaswinder Singh
2008-07-06 15:36     ` Fredrik Noring
2008-07-06 15:38       ` Jaswinder Singh
2008-07-06 16:54         ` David Woodhouse
2008-07-06 18:29           ` Fredrik Noring
2008-07-09 13:05             ` David Woodhouse [this message]
2008-07-10  7:38               ` Fredrik Noring
2008-07-10  8:53                 ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1215608750.11567.177.camel@pmac.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jaswinder@infradead.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kernelnewbies@nl.linux.org \
    --cc=lars@nocrew.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=noring@nocrew.org \
    --cc=tomas@nocrew.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®