From: Josh Triplett <josht@linux.vnet.ibm.com>
To: Daniel Guilak <guilak@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, trivial@kernel.org,
akpm@linux-foundation.org, torvalds@linux-foundation.org,
daniel@danielguilak.com
Subject: Re: [PATCH] init/version.c: Silenced sparse warning by declaring the version string.
Date: Tue, 08 Jul 2008 18:10:28 -0700 [thread overview]
Message-ID: <1215565828.3071.42.camel@josh-work.beaverton.ibm.com> (raw)
In-Reply-To: <1215552069.10304.6.camel@dguilak-desk>
On Tue, 2008-07-08 at 14:21 -0700, Daniel Guilak wrote:
> Signed-off-by: Daniel Guilak <daniel@danielguilak.com>
Looks reasonable.
Acked-by: Josh Triplett <josh@kernel.org>
> ---
> init/version.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/init/version.c b/init/version.c
> index 9d17d70..041fd82 100644
> --- a/init/version.c
> +++ b/init/version.c
> @@ -16,6 +16,7 @@
> #define version(a) Version_ ## a
> #define version_string(a) version(a)
>
> +extern int version_string(LINUX_VERSION_CODE);
> int version_string(LINUX_VERSION_CODE);
>
> struct uts_namespace init_uts_ns = {
next prev parent reply other threads:[~2008-07-09 1:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-08 21:21 Daniel Guilak
2008-07-09 1:10 ` Josh Triplett [this message]
2008-07-11 19:18 ` Andrew Morton
2008-07-14 19:02 ` Daniel Guilak
2008-07-14 19:04 ` [PATCH] init/version.c: Define version_string only if CONFIG_KALLSYMS is not defined Daniel Guilak
2008-07-14 19:38 ` Randy Dunlap
2008-07-14 21:20 ` Daniel Guilak
2008-07-14 21:25 ` Daniel Guilak
2008-07-14 22:07 ` Randy Dunlap
2008-07-14 22:29 ` Daniel Guilak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1215565828.3071.42.camel@josh-work.beaverton.ibm.com \
--to=josht@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=daniel@danielguilak.com \
--cc=guilak@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®