From: Daniel Guilak <guilak@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: trivial@kernel.org, akpm@linux-foundation.org,
torvalds@linux-foundation.org, daniel@danielguilak.com
Subject: [PATCH] init/version.c: Define version_string only if CONFIG_KALLSYMS is not defined.
Date: Mon, 14 Jul 2008 12:04:46 -0700 [thread overview]
Message-ID: <1216062286.6497.18.camel@dguilak-desk> (raw)
In-Reply-To: <1215552069.10304.6.camel@dguilak-desk>
int Version_* is only used with ksymoops, which is only needed (according to
README and Documentation/Changes) if CONFIG_KALLSYMS is NOT defined. Therefore
this patch defines version_string only if CONFIG_KALLSYMS is not defined.
Signed-off-by: Daniel Guilak <daniel@danielguilak.com>
---
init/version.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
Depends on "[PATCH] init/version.c: Silenced sparse warning by declaring the version string."
diff --git a/init/version.c b/init/version.c
index 041fd82..52a8b98 100644
--- a/init/version.c
+++ b/init/version.c
@@ -13,11 +13,13 @@
#include <linux/utsrelease.h>
#include <linux/version.h>
+#ifndef CONFIG_KALLSYMS
#define version(a) Version_ ## a
#define version_string(a) version(a)
extern int version_string(LINUX_VERSION_CODE);
int version_string(LINUX_VERSION_CODE);
+#endif
struct uts_namespace init_uts_ns = {
.kref = {
--
1.5.4.3
next prev parent reply other threads:[~2008-07-14 19:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-08 21:21 [PATCH] init/version.c: Silenced sparse warning by declaring the version string Daniel Guilak
2008-07-09 1:10 ` Josh Triplett
2008-07-11 19:18 ` Andrew Morton
2008-07-14 19:02 ` Daniel Guilak
2008-07-14 19:04 ` Daniel Guilak [this message]
2008-07-14 19:38 ` [PATCH] init/version.c: Define version_string only if CONFIG_KALLSYMS is not defined Randy Dunlap
2008-07-14 21:20 ` Daniel Guilak
2008-07-14 21:25 ` Daniel Guilak
2008-07-14 22:07 ` Randy Dunlap
2008-07-14 22:29 ` Daniel Guilak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216062286.6497.18.camel@dguilak-desk \
--to=guilak@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=daniel@danielguilak.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®