* [PATCH] rtc: fix reported IRQ rate for when HPET is enabled.
@ 2008-07-10 15:23 Paul Gortmaker
0 siblings, 0 replies; only message in thread
From: Paul Gortmaker @ 2008-07-10 15:23 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm, Paul Gortmaker
The IRQ rate reported back by the RTC is incorrect when
HPET is enabled.
Newer hardware that has HPET to emulate the legacy RTC
device gets this value wrong since after it sets the
rate, it returns before setting the variable used to
report the IRQ rate back to users of the device -- so
the set rate and the reported rate get out of sync.
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/char/rtc.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/char/rtc.c b/drivers/char/rtc.c
index 5f80a9d..909cac9 100644
--- a/drivers/char/rtc.c
+++ b/drivers/char/rtc.c
@@ -678,12 +678,13 @@ static int rtc_do_ioctl(unsigned int cmd, unsigned long arg, int kernel)
if (arg != (1<<tmp))
return -EINVAL;
+ rtc_freq = arg;
+
spin_lock_irqsave(&rtc_lock, flags);
if (hpet_set_periodic_freq(arg)) {
spin_unlock_irqrestore(&rtc_lock, flags);
return 0;
}
- rtc_freq = arg;
val = CMOS_READ(RTC_FREQ_SELECT) & 0xf0;
val |= (16 - tmp);
--
1.5.6.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-07-10 15:17 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-07-10 15:23 [PATCH] rtc: fix reported IRQ rate for when HPET is enabled Paul Gortmaker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome