* [PATCH] remove duplicate call to use_tsc_delay.
@ 2008-07-10 17:01 Glauber Costa
2008-07-10 17:21 ` Alok kataria
2008-07-10 17:47 ` Ingo Molnar
0 siblings, 2 replies; 3+ messages in thread
From: Glauber Costa @ 2008-07-10 17:01 UTC (permalink / raw)
To: linux-kernel; +Cc: tglx, mingo, x86
Integration generated a duplicate call to use_tsc_delay.
Particularly, the one that is done before we check for general
tsc usability seems wrong.
Signed-off-by: Glauber Costa <gcosta@redhat.com>
---
arch/x86/kernel/tsc.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index 4a775d0..3c36f92 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -513,7 +513,6 @@ void __init tsc_init(void)
*/
for_each_possible_cpu(cpu)
set_cyc2ns_scale(cpu_khz, cpu);
- use_tsc_delay();
if (tsc_disabled > 0)
return;
--
1.5.5.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] remove duplicate call to use_tsc_delay.
2008-07-10 17:01 [PATCH] remove duplicate call to use_tsc_delay Glauber Costa
@ 2008-07-10 17:21 ` Alok kataria
2008-07-10 17:47 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Alok kataria @ 2008-07-10 17:21 UTC (permalink / raw)
To: Glauber Costa; +Cc: linux-kernel, tglx, mingo, x86, akataria
My bad,
Acked-by: Alok N Kataria <akataria@vmware.com>
Thanks !!.
--
Alok
On Thu, Jul 10, 2008 at 10:01 AM, Glauber Costa <gcosta@redhat.com> wrote:
> Integration generated a duplicate call to use_tsc_delay.
> Particularly, the one that is done before we check for general
> tsc usability seems wrong.
>
> Signed-off-by: Glauber Costa <gcosta@redhat.com>
> ---
> arch/x86/kernel/tsc.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
> index 4a775d0..3c36f92 100644
> --- a/arch/x86/kernel/tsc.c
> +++ b/arch/x86/kernel/tsc.c
> @@ -513,7 +513,6 @@ void __init tsc_init(void)
> */
> for_each_possible_cpu(cpu)
> set_cyc2ns_scale(cpu_khz, cpu);
> - use_tsc_delay();
>
> if (tsc_disabled > 0)
> return;
> --
> 1.5.5.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] remove duplicate call to use_tsc_delay.
2008-07-10 17:01 [PATCH] remove duplicate call to use_tsc_delay Glauber Costa
2008-07-10 17:21 ` Alok kataria
@ 2008-07-10 17:47 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2008-07-10 17:47 UTC (permalink / raw)
To: Glauber Costa; +Cc: linux-kernel, tglx, x86
* Glauber Costa <gcosta@redhat.com> wrote:
> Integration generated a duplicate call to use_tsc_delay. Particularly,
> the one that is done before we check for general tsc usability seems
> wrong.
applied to tip/x86/core - thanks Glauber.
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-07-10 17:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-07-10 17:01 [PATCH] remove duplicate call to use_tsc_delay Glauber Costa
2008-07-10 17:21 ` Alok kataria
2008-07-10 17:47 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®