From: Julien Grossholtz <julien.grossholtz@savoirfairelinux.com>
To: linus walleij <linus.walleij@linaro.org>
Cc: gnurou@gmail.com, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Dan Carpenter <dan.carpenter@oracle.com>,
kernel@savoirfairelinux.com
Subject: Re: [PATCH] gpio: TS-4800: remove useless bgpio_init flags
Date: Wed, 10 Feb 2016 12:17:26 -0500 (EST) [thread overview]
Message-ID: <1215789090.353270.1455124646607.JavaMail.zimbra@savoirfairelinux.com> (raw)
In-Reply-To: <1455123514-17152-1-git-send-email-julien.grossholtz@savoirfairelinux.com>
From: "Julien Grossholtz" <julien.grossholtz@savoirfairelinux.com>
To: "linus walleij" <linus.walleij@linaro.org>
Cc: gnurou@gmail.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, "Dan Carpenter" <dan.carpenter@oracle.com>, kernel@savoirfairelinux.com, "Julien Grossholtz" <julien.grossholtz@savoirfairelinux.com>
Sent: Wednesday, February 10, 2016 11:58:34 AM
Subject: [PATCH] gpio: TS-4800: remove useless bgpio_init flags
No flags are required for bgpio_init in the TS-4800 gpio driver. This
patch set zero instead. The driver will have the same behaviour since
the | operator between the flags already resulted to zero.
There is a typo here, I will send it again.
Fixes: 5041e791440a ("gpio: add TS-4800 fpga GPIO support")
Signed-off-by: Julien Grossholtz <julien.grossholtz@savoirfairelinux.com>
---
drivers/gpio/gpio-ts4800.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-ts4800.c b/drivers/gpio/gpio-ts4800.c
index c4908a4..9da79e4 100644
--- a/drivers/gpio/gpio-ts4800.c
+++ b/drivers/gpio/gpio-ts4800.c
@@ -48,8 +48,7 @@ static int ts4800_gpio_probe(struct platform_device *pdev)
retval = bgpio_init(chip, &pdev->dev, 2, base_addr + INPUT_REG_OFFSET,
base_addr + OUTPUT_REG_OFFSET, NULL,
- base_addr + DIRECTION_REG_OFFSET, NULL,
- BGPIOF_BIG_ENDIAN & BGPIOF_BIG_ENDIAN_BYTE_ORDER);
+ base_addr + DIRECTION_REG_OFFSET, NULL, 0);
if (retval) {
dev_err(&pdev->dev, "bgpio_init failed\n");
return retval;
--
2.5.0
prev parent reply other threads:[~2016-02-10 17:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 16:58 Julien Grossholtz
2016-02-10 17:17 ` Julien Grossholtz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1215789090.353270.1455124646607.JavaMail.zimbra@savoirfairelinux.com \
--to=julien.grossholtz@savoirfairelinux.com \
--cc=dan.carpenter@oracle.com \
--cc=gnurou@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®