From: Johannes Berg <johannes@sipsolutions.net>
To: Andi Kleen <andi@firstfloor.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next 00/11] remove CONFIG_KMOD
Date: Mon, 14 Jul 2008 09:52:33 +0200 [thread overview]
Message-ID: <1216021953.11189.4.camel@johannes.berg> (raw)
In-Reply-To: <87zlolzv15.fsf@basil.nowhere.org>
[-- Attachment #1: Type: text/plain, Size: 1362 bytes --]
On Sun, 2008-07-13 at 17:03 +0200, Andi Kleen wrote:
> Johannes Berg <johannes@sipsolutions.net> writes:
>
> > I've rebased this patch series against -next-20080708 (one conflict
> > against ftrace, another against BKL pushdown) and fixed the things
> > Adrian Bunk pointed out.
>
> You forgot to say why you want to remove that?
Indeed, I did. Well for one, it's pointless. As Rusty pointed out, you
can achieve pretty much the same thing by putting /bin/true into the
modprobe path, and the option protects only very little code.
Secondly, the option has a lot of potential for misuse. A lot of people
tend to unset it because they think they can load modules manually, but
then they forget all the dependencies that aren't link-time resolvable
like crypto providers: if you request an encryption with RC4 the arc4
module will be loaded by the crypto provider code, but this isn't a
link-time dependency so modprobe cannot resolve it. We're getting bug
reports like that probably about bi-weekly or so and I suspect distros
are getting many more.
Hence, it's beneficial to remove the option, those who really do need to
turn off module autoloading can still do it at runtime which even
benefits them because it allows them finer-grained control, and others
are left with less potential to screw up their kernel config.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2008-07-14 7:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-09 8:28 Johannes Berg
2008-07-09 8:28 ` [PATCH -next 01/11] make CONFIG_KMOD invisible Johannes Berg
2008-07-09 8:28 ` [PATCH -next 02/11] remove CONFIG_KMOD from core kernel code Johannes Berg
2008-07-09 8:28 ` [PATCH -next 03/11] rework try_then_request_module to do less in non-modular kernels Johannes Berg
2008-07-09 8:28 ` [PATCH -next 04/11] remove CONFIG_KMOD from drivers Johannes Berg
2008-07-09 8:28 ` [PATCH -next 05/11] remove CONFIG_KMOD from sparc64 Johannes Berg
2008-07-09 8:28 ` [PATCH -next 06/11] remove CONFIG_KMOD from fs Johannes Berg
2008-07-09 8:28 ` [PATCH -next 07/11] remove CONFIG_KMOD from sound Johannes Berg
2008-07-09 17:33 ` Takashi Iwai
2008-07-09 8:28 ` [PATCH -next 08/11] remove CONFIG_KMOD from net Johannes Berg
2008-07-09 8:28 ` [PATCH -next 09/11] remove CONFIG_KMOD from lib Johannes Berg
2008-07-09 8:28 ` [PATCH -next 10/11] remove mention of CONFIG_KMOD from documentation Johannes Berg
2008-07-09 8:28 ` [PATCH -next 11/11] remove CONFIG_KMOD Johannes Berg
2008-07-13 15:03 ` [PATCH -next 00/11] " Andi Kleen
2008-07-14 0:38 ` Rusty Russell
2008-07-14 7:52 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216021953.11189.4.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=andi@firstfloor.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®