From: Johannes Berg <johannes@sipsolutions.net>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Christoph Hellwig <hch@infradead.org>, linux-kernel@vger.kernel.org
Subject: [PATCH -next 03/11] rework try_then_request_module to do less in non-modular kernels
Date: Wed, 09 Jul 2008 10:28:37 +0200 [thread overview]
Message-ID: <20080709082903.125204000@sipsolutions.net> (raw)
In-Reply-To: <20080709082834.942992000@sipsolutions.net>
[-- Attachment #1: 005-config-kmod-try-then-rework.patch --]
[-- Type: text/plain, Size: 953 bytes --]
This reworks try_then_request_module to only invoke the "lookup"
function "x" once when the kernel is not modular.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
include/linux/kmod.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- everything.orig/include/linux/kmod.h 2008-07-08 22:00:25.000000000 +0200
+++ everything/include/linux/kmod.h 2008-07-08 22:00:26.000000000 +0200
@@ -29,11 +29,12 @@
/* modprobe exit status on success, -ve on error. Return value
* usually useless though. */
extern int request_module(const char * name, ...) __attribute__ ((format (printf, 1, 2)));
+#define try_then_request_module(x, mod...) ((x) ?: (request_module(mod), (x)))
#else
static inline int request_module(const char * name, ...) { return -ENOSYS; }
+#define try_then_request_module(x, mod...) (x)
#endif
-#define try_then_request_module(x, mod...) ((x) ?: (request_module(mod), (x)))
struct key;
struct file;
--
next prev parent reply other threads:[~2008-07-09 12:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-09 8:28 [PATCH -next 00/11] remove CONFIG_KMOD Johannes Berg
2008-07-09 8:28 ` [PATCH -next 01/11] make CONFIG_KMOD invisible Johannes Berg
2008-07-09 8:28 ` [PATCH -next 02/11] remove CONFIG_KMOD from core kernel code Johannes Berg
2008-07-09 8:28 ` Johannes Berg [this message]
2008-07-09 8:28 ` [PATCH -next 04/11] remove CONFIG_KMOD from drivers Johannes Berg
2008-07-09 8:28 ` [PATCH -next 05/11] remove CONFIG_KMOD from sparc64 Johannes Berg
2008-07-09 8:28 ` [PATCH -next 06/11] remove CONFIG_KMOD from fs Johannes Berg
2008-07-09 8:28 ` [PATCH -next 07/11] remove CONFIG_KMOD from sound Johannes Berg
2008-07-09 17:33 ` Takashi Iwai
2008-07-09 8:28 ` [PATCH -next 08/11] remove CONFIG_KMOD from net Johannes Berg
2008-07-09 8:28 ` [PATCH -next 09/11] remove CONFIG_KMOD from lib Johannes Berg
2008-07-09 8:28 ` [PATCH -next 10/11] remove mention of CONFIG_KMOD from documentation Johannes Berg
2008-07-09 8:28 ` [PATCH -next 11/11] remove CONFIG_KMOD Johannes Berg
2008-07-13 15:03 ` [PATCH -next 00/11] " Andi Kleen
2008-07-14 0:38 ` Rusty Russell
2008-07-14 7:52 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080709082903.125204000@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome