From: David Woodhouse <dwmw2@infradead.org>
To: Jaswinder Singh <jaswinder@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
kernelnewbies <kernelnewbies@nl.linux.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>,
andi@firstfloor.org
Subject: Re: [PATCH] x86: traps and do_traps under one hood
Date: Tue, 15 Jul 2008 07:21:43 -0700 [thread overview]
Message-ID: <1216131703.27455.245.camel@shinybook.infradead.org> (raw)
In-Reply-To: <1216119158.21749.5.camel@jaswinder.satnam>
On Tue, 2008-07-15 at 16:22 +0530, Jaswinder Singh wrote:
> Declaring x86 traps under one hood.
> Declaring x86 do_traps before defining them.
> arch/x86/kernel/traps_32.c | 20 ---------
> arch/x86/kernel/traps_64.c | 21 ----------
> include/asm-x86/mach-default/mach_traps.h | 62 +++++++++++++++++++++++++++++
You put these back in mach-default/mach_traps.h but does that cover all
possibilities? What about other machine types?
Looking at the ifdefs you introduced in that header, it seems there's
more scope for unification here (although it makes sense for that to
come later).
--
dwmw2
prev parent reply other threads:[~2008-07-15 14:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-15 10:52 Jaswinder Singh
2008-07-15 13:51 ` Alexander van Heukelum
2008-07-15 15:54 ` Jaswinder Singh
2008-07-15 14:21 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216131703.27455.245.camel@shinybook.infradead.org \
--to=dwmw2@infradead.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andi@firstfloor.org \
--cc=jaswinder@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernelnewbies@nl.linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®