mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jaswinder Singh <jaswinder@infradead.org>
To: Alexander van Heukelum <heukelum@fastmail.fm>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	kernelnewbies <kernelnewbies@nl.linux.org>,
	kernel-janitors <kernel-janitors@vger.kernel.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] x86: traps and do_traps under one hood
Date: Tue, 15 Jul 2008 21:24:09 +0530	[thread overview]
Message-ID: <1216137250.2747.12.camel@jaswinder.satnam> (raw)
In-Reply-To: <1216129914.20462.1263591561@webmail.messagingengine.com>

Hello Alexander,

On Tue, 2008-07-15 at 15:51 +0200, Alexander van Heukelum wrote:

> 
> I think moving the declarations to a header file is a good thing,
> but I don't think mach_traps.h is a suitable place. 

I CC new patch to you : [PATCH] x86: Introducing asm-x86/traps.h

> The definitions
> of the functions are in entry_32.S and entry_64.S, so I would suggest
> making a new header include/asm-x86/entry.h. Some other ENTRY's
> (like system_call and some xen-specific ones) would then also fit
> in this header.
> 
> What do you think?

I did this for traps_32.c and traps_64.c because they are complaining
that traps are defined but not declared.

Thank you,

Jaswinder Singh.


  reply	other threads:[~2008-07-15 15:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-15 10:52 Jaswinder Singh
2008-07-15 13:51 ` Alexander van Heukelum
2008-07-15 15:54   ` Jaswinder Singh [this message]
2008-07-15 14:21 ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1216137250.2747.12.camel@jaswinder.satnam \
    --to=jaswinder@infradead.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=dwmw2@infradead.org \
    --cc=heukelum@fastmail.fm \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kernelnewbies@nl.linux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®