* [PATCH/RESEND] PCI:pciehp:remove unnecessary volatile in struct controller
@ 2008-07-16 14:54 tom.leiming
2008-07-16 15:47 ` Jesse Barnes
0 siblings, 1 reply; 2+ messages in thread
From: tom.leiming @ 2008-07-16 14:54 UTC (permalink / raw)
To: jbarnes, kristen.c.accardi; +Cc: linux-pci, linux-kernel, Ming Lei
From: Ming Lei <tom.leiming@gmail.com>
Proper memory barriers have been added to order accesses
to ->cmd_busy, so volatile declaration for cmd_busy can
be removed.
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
---
drivers/pci/hotplug/pciehp.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h
index 79c9dda..5e2becd 100644
--- a/drivers/pci/hotplug/pciehp.h
+++ b/drivers/pci/hotplug/pciehp.h
@@ -96,7 +96,7 @@ struct controller {
u32 slot_cap;
u8 cap_base;
struct timer_list poll_timer;
- volatile int cmd_busy;
+ int cmd_busy;
unsigned int no_cmd_complete:1;
};
--
1.5.6.rc2.45.gdc92c
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH/RESEND] PCI:pciehp:remove unnecessary volatile in struct controller
2008-07-16 14:54 [PATCH/RESEND] PCI:pciehp:remove unnecessary volatile in struct controller tom.leiming
@ 2008-07-16 15:47 ` Jesse Barnes
0 siblings, 0 replies; 2+ messages in thread
From: Jesse Barnes @ 2008-07-16 15:47 UTC (permalink / raw)
To: tom.leiming; +Cc: kristen.c.accardi, linux-pci, linux-kernel
On Wednesday, July 16, 2008 7:54 am tom.leiming@gmail.com wrote:
> From: Ming Lei <tom.leiming@gmail.com>
>
> Proper memory barriers have been added to order accesses
> to ->cmd_busy, so volatile declaration for cmd_busy can
> be removed.
>
> Signed-off-by: Ming Lei <tom.leiming@gmail.com>
> ---
> drivers/pci/hotplug/pciehp.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h
> index 79c9dda..5e2becd 100644
> --- a/drivers/pci/hotplug/pciehp.h
> +++ b/drivers/pci/hotplug/pciehp.h
> @@ -96,7 +96,7 @@ struct controller {
> u32 slot_cap;
> u8 cap_base;
> struct timer_list poll_timer;
> - volatile int cmd_busy;
> + int cmd_busy;
> unsigned int no_cmd_complete:1;
> };
Yeah I saw the first one, just hadn't had a chance to reply/apply yet. I just
applied it to my linux-next branch and pushed.
Jesse
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-16 15:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-07-16 14:54 [PATCH/RESEND] PCI:pciehp:remove unnecessary volatile in struct controller tom.leiming
2008-07-16 15:47 ` Jesse Barnes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®