From: David Dillow <dave@thedillows.org>
To: Jaswinder Singh <jaswinder@infradead.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [GIT PULL]: firmware patches for building firmware into kernel
Date: Fri, 08 Aug 2008 00:10:46 -0400 [thread overview]
Message-ID: <1218168646.17642.27.camel@obelisk.thedillows.org> (raw)
In-Reply-To: <1218166270.2540.9.camel@jaswinder.satnam>
On Fri, 2008-08-08 at 09:01 +0530, Jaswinder Singh wrote:
> On Thu, 2008-08-07 at 14:21 -0400, David Dillow wrote:
> > I just looked at the tree; it still has locking issues, and needs
> > further review. You must protect the list from modification while you
> > iterate it looking for an match on the requested firmware.
>
> So here is updated patch:
I'll take a closer look when I'm awake, but there are some nitpicky
style issues remaining:
> diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
> index 6074321..71ec20d 100644
> --- a/drivers/base/firmware_class.c
> +++ b/drivers/base/firmware_class.c
> @@ -568,19 +569,22 @@ void release_firmware(const struct firmware *fw)
> {
> struct firmware_list *flst;
>
> + mutex_lock(&fw_lock);
> if (fw)
> list_for_each_entry(flst, &firmwarelist, list)
> if (fw == flst->fw) {
> printk(KERN_INFO
> "firmware: releasing %s count %d\n",
> flst->name, flst->count);
> - mutex_lock(&fw_lock);
> flst->count--;
> - mutex_unlock(&fw_lock);
> - if (flst->count == 0)
> - __release_firmware(fw, flst);
> - return;
> + if (flst->count == 0) {
> + mutex_unlock(&fw_lock);
> + return __release_firmware(fw, flst);
> + }
> + goto out;
> }
> +out:
> + mutex_unlock(&fw_lock);
> }
You don't need the 'goto out', a break will work fine. And you'll not be
pressed up against the right side of the screen if you just do
if (!fw)
return;
at the top of the function.
> @@ -598,6 +602,7 @@ void release_firmware_all(const struct firmware *fw)
I still don't like this exception to the get/put ref-counting. Is this
used anywhere else in your series, or was typhoon the only one?
> > Also, was it legal to call release_firmware() from an atomic context? It can now
> > sleep, which may be an issue...
>
> yes, release_firmware can sleep.
> So now release_firmware also joined the family of request_firmware.
The question wasn't if it can sleep now, it was if it could sleep before
you started changing it. I now know that it has always called vfree(),
so it has always needed to be able to sleep.
> Any how release_firmware will be called below request_firmware or during
> exit, I do not think this will make any issue.
I need to run down code to see if my thoughts are realistic, but say
eth0 was a typhoon:
modprobe typhoon
ip link set eth0 up
rmmod typhoon
<firmware unloaded>
<sleep in typhoon_remove_one() waiting for 'ip link set eth0 down'>
<Tx timeout, needing to reset and reload firmware>
Boom.
Dave
next prev parent reply other threads:[~2008-08-08 4:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-07 16:56 Jaswinder Singh
2008-08-07 17:30 ` David Dillow
2008-08-07 17:34 ` Jaswinder Singh
2008-08-07 18:21 ` David Dillow
2008-08-08 1:38 ` Jaswinder Singh
2008-08-08 2:59 ` David Dillow
2008-08-08 3:39 ` Jaswinder Singh
2008-08-08 4:25 ` David Dillow
2008-08-08 6:08 ` Jaswinder Singh
2008-08-08 3:31 ` Jaswinder Singh
2008-08-08 4:10 ` David Dillow [this message]
2008-08-08 4:33 ` Jaswinder Singh
2008-08-08 12:36 ` David Dillow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218168646.17642.27.camel@obelisk.thedillows.org \
--to=dave@thedillows.org \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dwmw2@infradead.org \
--cc=jaswinder@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®