Re: [GIT PULL]: firmware patches for building firmware into kernel

[Jaswinder Singh <jaswinder@infradead.org>]

Hello Dave,

On Fri, 2008-08-08 at 00:25 -0400, David Dillow wrote:
> On Fri, 2008-08-08 at 09:09 +0530, Jaswinder Singh wrote:
> > On Thu, 2008-08-07 at 22:59 -0400, David Dillow wrote:
> > > I don't like releasing the firmware before the pci_unregister_driver()
> > > call. I worry about ordering issues during cleanup, though I'll admit I
> > > have not yet researched if it will be a problem. In any event, if you're
> > > going to request it once per adapter in typhoon_init_one(), then it
> > > should be in the per-device struct, and released in
> > > typhoon_remove_one().
> >
> > Here is updated patch :
> 
> You've fixed one part of the issues I described, but I think you've left
> open the possibility of dangling pointers when one card in a multi NIC
> system fails to come up. Again, I need to track down the code to see if
> I'm all wet or not.
> 

That's why I introduced firmware_release_all() for buggy drivers.

I think firmware_release_all() is best for you case.

Thank you,

Jaswinder Singh.