From: Evgeniy Polyakov <zbr@ioremap.net>
To: David Miller <davem@davemloft.net>, "fw@strlen.de" <fw@strlen.de>
Cc: "dvyukov@google.com" <dvyukov@google.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] connector: bump skb->users before callback invocation
Date: Mon, 11 Jan 2016 23:03:22 +0300 [thread overview]
Message-ID: <1218671452542602@web12j.yandex.ru> (raw)
In-Reply-To: <20160104.214733.921867451376206917.davem@davemloft.net>
Hi everyone
Thanks for fixing and quick pushing of this bug.
05.01.2016, 05:47, "David Miller" <davem@davemloft.net>:
> From: Florian Westphal <fw@strlen.de>
> Date: Thu, 31 Dec 2015 14:26:33 +0100
>
>> Dmitry reports memleak with syskaller program.
>> Problem is that connector bumps skb usecount but might not invoke callback.
>>
>> So move skb_get to where we invoke the callback.
>>
>> Reported-by: Dmitry Vyukov <dvyukov@google.com>
>> Signed-off-by: Florian Westphal <fw@strlen.de>
>
> Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2016-01-11 20:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-31 11:51 net/netlink: memory leak in netlink_sendmsg Dmitry Vyukov
2015-12-31 13:26 ` [PATCH] connector: bump skb->users before callback invocation Florian Westphal
2016-01-05 2:47 ` David Miller
2016-01-11 20:03 ` Evgeniy Polyakov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218671452542602@web12j.yandex.ru \
--to=zbr@ioremap.net \
--cc=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=fw@strlen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®