From: Robert Richter <robert.richter@amd.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Robert Richter <robert.richter@amd.com>,
Jan Beulich <jbeulich@novell.com>,
Yinghai Lu <yhlu.kernel@gmail.com>
Subject: [PATCH] x86: fix: do not run code in amd_bus.c on non-AMD CPUs
Date: Fri, 22 Aug 2008 20:23:37 +0200 [thread overview]
Message-ID: <1219429418-29023-1-git-send-email-robert.richter@amd.com> (raw)
In-Reply-To: <48AD82D5.76E4.0078.0@novell.com>
On 21.08.08 13:59:33, Jan Beulich wrote:
> Even worse - this would even try to access the MSR on non-AMD CPUs
> (currently probably prevented just by the fact that only AMD ones use
> family values of 0x10 or higher).
This patch adds cpu vendor check to the postcore_initcalls.
Cc: Jan Beulich <jbeulich@novell.com>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>
Signed-off-by: Robert Richter <robert.richter@amd.com>
---
arch/x86/pci/amd_bus.c | 19 ++++++++++++++++---
1 files changed, 16 insertions(+), 3 deletions(-)
diff --git a/arch/x86/pci/amd_bus.c b/arch/x86/pci/amd_bus.c
index dbf5323..4a6f1a6 100644
--- a/arch/x86/pci/amd_bus.c
+++ b/arch/x86/pci/amd_bus.c
@@ -555,9 +555,11 @@ static int __init early_fill_mp_bus_info(void)
return 0;
}
-postcore_initcall(early_fill_mp_bus_info);
+#else /* !CONFIG_X86_64 */
-#endif
+static int __init early_fill_mp_bus_info(void) { return 0; }
+
+#endif /* !CONFIG_X86_64 */
/* common 32/64 bit code */
@@ -583,4 +585,15 @@ static int __init enable_pci_io_ecs(void)
return 0;
}
-postcore_initcall(enable_pci_io_ecs);
+static int __init amd_postcore_init(void)
+{
+ if (boot_cpu_data.x86_vendor != X86_VENDOR_AMD)
+ return 0;
+
+ early_fill_mp_bus_info();
+ enable_pci_io_ecs();
+
+ return 0;
+}
+
+postcore_initcall(amd_postcore_init);
--
1.5.6.4
next prev parent reply other threads:[~2008-08-22 18:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 12:59 patch "x86: MOVE PCI IO ECS code to x86/pci" breaks CPU hotplug Jan Beulich
2008-08-21 13:29 ` Robert Richter
2008-08-21 16:25 ` Yinghai Lu
2008-08-21 16:46 ` Robert Richter
2008-08-22 18:23 ` Robert Richter [this message]
2008-08-22 18:47 ` [PATCH] x86: fix: do not run code in amd_bus.c on non-AMD CPUs Yinghai Lu
2008-08-22 18:51 ` Robert Richter
2008-08-22 18:57 ` Yinghai Lu
2008-08-22 19:13 ` Robert Richter
2008-08-22 18:23 ` [PATCH] x86: fix: make PCI ECS for AMD CPUs hotplug capable Robert Richter
2008-08-22 18:56 ` Yinghai Lu
2008-08-22 19:07 ` Robert Richter
2008-08-22 19:10 ` Yinghai Lu
2008-08-22 19:20 ` Robert Richter
2008-08-23 15:37 ` Ingo Molnar
2008-08-23 15:39 ` Ingo Molnar
2008-08-25 9:00 ` [PATCH] x86: fix: make PCI ECS for AMD CPUs hotplug capable (-v2) Robert Richter
2008-08-25 9:12 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219429418-29023-1-git-send-email-robert.richter@amd.com \
--to=robert.richter@amd.com \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®