mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Robert Richter <robert.richter@amd.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>,
	Jan Beulich <jbeulich@novell.com>,
	Yinghai Lu <yhlu.kernel@gmail.com>
Subject: Re: [PATCH] x86: fix: make PCI ECS for AMD CPUs hotplug capable (-v2)
Date: Mon, 25 Aug 2008 11:12:38 +0200	[thread overview]
Message-ID: <20080825091238.GA9114@elte.hu> (raw)
In-Reply-To: <1219654859-1010-1-git-send-email-robert.richter@amd.com>


* Robert Richter <robert.richter@amd.com> wrote:

> Until now, PCI ECS setup was performed at boot time only and for cpus 
> that are enabled then. This patch fixes this and adds cpu hotplug.

i already had v1 applied to tip/x86/urgent, so i took the -v2 delta and 
queued it up in tip/x86/cleanups - see the commit below.

	Ingo

--------------->
>From ed21763e7b0b3fb50e4efd9d4bc17ef5b035d304 Mon Sep 17 00:00:00 2001
From: Robert Richter <robert.richter@amd.com>
Date: Fri, 22 Aug 2008 20:23:38 +0200
Subject: [PATCH] x86: cleanup in amd_cpu_notify()

small coding style fix.

Signed-off-by: Robert Richter <robert.richter@amd.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/pci/amd_bus.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/pci/amd_bus.c b/arch/x86/pci/amd_bus.c
index 6a0fca7..22e0576 100644
--- a/arch/x86/pci/amd_bus.c
+++ b/arch/x86/pci/amd_bus.c
@@ -580,7 +580,7 @@ static int __cpuinit amd_cpu_notify(struct notifier_block *self,
 				    unsigned long action, void *hcpu)
 {
 	int cpu = (long)hcpu;
-	switch(action) {
+	switch (action) {
 	case CPU_ONLINE:
 	case CPU_ONLINE_FROZEN:
 		smp_call_function_single(cpu, enable_pci_io_ecs, NULL, 0);

      reply	other threads:[~2008-08-25  9:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-21 12:59 patch "x86: MOVE PCI IO ECS code to x86/pci" breaks CPU hotplug Jan Beulich
2008-08-21 13:29 ` Robert Richter
2008-08-21 16:25   ` Yinghai Lu
2008-08-21 16:46     ` Robert Richter
2008-08-22 18:23 ` [PATCH] x86: fix: do not run code in amd_bus.c on non-AMD CPUs Robert Richter
2008-08-22 18:47   ` Yinghai Lu
2008-08-22 18:51     ` Robert Richter
2008-08-22 18:57       ` Yinghai Lu
2008-08-22 19:13         ` Robert Richter
2008-08-22 18:23 ` [PATCH] x86: fix: make PCI ECS for AMD CPUs hotplug capable Robert Richter
2008-08-22 18:56   ` Yinghai Lu
2008-08-22 19:07     ` Robert Richter
2008-08-22 19:10       ` Yinghai Lu
2008-08-22 19:20         ` Robert Richter
2008-08-23 15:37   ` Ingo Molnar
2008-08-23 15:39     ` Ingo Molnar
2008-08-25  9:00     ` [PATCH] x86: fix: make PCI ECS for AMD CPUs hotplug capable (-v2) Robert Richter
2008-08-25  9:12       ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080825091238.GA9114@elte.hu \
    --to=mingo@elte.hu \
    --cc=jbeulich@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robert.richter@amd.com \
    --cc=tglx@linutronix.de \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®