[PATCH 1/1] ALSA: add dummy function to support shared mmap in nommu Blackfin arch (v2)

[PATCH 1/1] ALSA: add dummy function to support shared mmap in nommu Blackfin arch (v2)

[Bryan Wu]

From: Cliff Cai <cliff.cai@analog.com>

v1-v2:
 - only adding this dummy function in nommu arch

Signed-off-by: Cliff Cai <cliff.cai@analog.com>
Signed-off-by: Bryan Wu <cooloney@kernel.org>
---
 sound/core/pcm_native.c |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)

diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
index c49b9d9..1e88cde 100644
--- a/sound/core/pcm_native.c
+++ b/sound/core/pcm_native.c
@@ -3391,6 +3391,14 @@ out:
 }
 #endif /* CONFIG_SND_SUPPORT_OLD_API */
 
+#ifndef CONFIG_MMU
+unsigned long dummy_get_unmapped_area(struct file *file, unsigned long addr,
+				      unsigned long len, unsigned long pgoff, unsigned long flags)
+{
+	return 0;
+}
+#endif
+
 /*
  *  Register section
  */
@@ -3407,6 +3415,9 @@ const struct file_operations snd_pcm_f_ops[2] = {
 		.compat_ioctl = 	snd_pcm_ioctl_compat,
 		.mmap =			snd_pcm_mmap,
 		.fasync =		snd_pcm_fasync,
+#ifndef CONFIG_MMU
+		.get_unmapped_area =	dummy_get_unmapped_area,
+#endif
 	},
 	{
 		.owner =		THIS_MODULE,
@@ -3419,5 +3430,8 @@ const struct file_operations snd_pcm_f_ops[2] = {
 		.compat_ioctl = 	snd_pcm_ioctl_compat,
 		.mmap =			snd_pcm_mmap,
 		.fasync =		snd_pcm_fasync,
+#ifndef CONFIG_MMU
+		.get_unmapped_area =	dummy_get_unmapped_area,
+#endif
 	}
 };
-- 
1.5.6

Re: [PATCH 1/1] ALSA: add dummy function to support shared mmap in nommu Blackfin arch (v2)

[Mike Frysinger]

On Tue, Sep 2, 2008 at 5:58 AM, Bryan Wu wrote:
> From: Cliff Cai <cliff.cai@analog.com>
>
> v1-v2:
>  - only adding this dummy function in nommu arch
>
> Signed-off-by: Cliff Cai <cliff.cai@analog.com>
> Signed-off-by: Bryan Wu <cooloney@kernel.org>
> ---
>  sound/core/pcm_native.c |   14 ++++++++++++++
>  1 files changed, 14 insertions(+), 0 deletions(-)
>
> diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
> index c49b9d9..1e88cde 100644
> --- a/sound/core/pcm_native.c
> +++ b/sound/core/pcm_native.c
> @@ -3391,6 +3391,14 @@ out:
>  }
>  #endif /* CONFIG_SND_SUPPORT_OLD_API */
>
> +#ifndef CONFIG_MMU
> +unsigned long dummy_get_unmapped_area(struct file *file, unsigned long addr,
> +                                     unsigned long len, unsigned long pgoff, unsigned long flags)
> +{
> +       return 0;
> +}
> +#endif

if you had:
#else
# define dummy_get_unmapped_area NULL
#endif
then you could avoid #ifdef in the rest of the file ...
-mike

Re: [PATCH 1/1] ALSA: add dummy function to support shared mmap in nommu Blackfin arch (v2)

[Bryan Wu]

On Tue, Sep 2, 2008 at 9:37 PM, Mike Frysinger <vapier.adi@gmail.com> wrote:
> On Tue, Sep 2, 2008 at 5:58 AM, Bryan Wu wrote:
>> From: Cliff Cai <cliff.cai@analog.com>
>>
>> v1-v2:
>>  - only adding this dummy function in nommu arch
>>
>> Signed-off-by: Cliff Cai <cliff.cai@analog.com>
>> Signed-off-by: Bryan Wu <cooloney@kernel.org>
>> ---
>>  sound/core/pcm_native.c |   14 ++++++++++++++
>>  1 files changed, 14 insertions(+), 0 deletions(-)
>>
>> diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
>> index c49b9d9..1e88cde 100644
>> --- a/sound/core/pcm_native.c
>> +++ b/sound/core/pcm_native.c
>> @@ -3391,6 +3391,14 @@ out:
>>  }
>>  #endif /* CONFIG_SND_SUPPORT_OLD_API */
>>
>> +#ifndef CONFIG_MMU
>> +unsigned long dummy_get_unmapped_area(struct file *file, unsigned long addr,
>> +                                     unsigned long len, unsigned long pgoff, unsigned long flags)
>> +{
>> +       return 0;
>> +}
>> +#endif
>
> if you had:
> #else
> # define dummy_get_unmapped_area NULL
> #endif
> then you could avoid #ifdef in the rest of the file ...
> -mike
>

Right, I will refresh this patch.

-Bryan