From: Ilya Yanok <yanok@emcraft.com>
To: linux-raid@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, wd@denx.de,
Yuri Tikhonov <yur@emcraft.com>
Subject: [PATCH] ASYNC_TX: fix the bug in async_tx_run_dependencies
Date: Thu, 4 Sep 2008 01:43:51 +0400 [thread overview]
Message-ID: <1220478231-8725-1-git-send-email-yanok@emcraft.com> (raw)
From: Yuri Tikhonov <yur@emcraft.com>
Should clear the next pointer of the TX if we are sure that the
next TX (say NXT) will be submitted to the channel too. Overwise,
we break the chain of descriptors, because we lose the information
about the next descriptor to run. So next time, when invoke
async_tx_run_dependencies() with TX, it's TX->next will be NULL, and
NXT will be never submitted.
Signed-off-by: Yuri Tikhonov <yur@emcraft.com>
---
crypto/async_tx/async_tx.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/crypto/async_tx/async_tx.c b/crypto/async_tx/async_tx.c
index 85eaf7b..e8362c1 100644
--- a/crypto/async_tx/async_tx.c
+++ b/crypto/async_tx/async_tx.c
@@ -137,7 +137,8 @@ async_tx_run_dependencies(struct dma_async_tx_descriptor *tx)
spin_lock_bh(&next->lock);
next->parent = NULL;
_next = next->next;
- next->next = NULL;
+ if (_next && _next->chan == chan)
+ next->next = NULL;
spin_unlock_bh(&next->lock);
next->tx_submit(next);
--
1.5.6.3
next reply other threads:[~2008-09-03 22:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-03 21:43 Ilya Yanok [this message]
2008-09-04 21:19 ` Andrew Morton
2008-09-04 23:24 ` Dan Williams
2008-09-05 0:03 ` Dan Williams
2008-09-05 10:17 ` Ilya Yanok
2008-09-05 9:15 ` Ilya Yanok
2008-09-05 13:06 ` Wolfgang Denk
2008-09-05 13:16 ` Ilya Yanok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1220478231-8725-1-git-send-email-yanok@emcraft.com \
--to=yanok@emcraft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=wd@denx.de \
--cc=yur@emcraft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®