mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Rakib Mullick <rakib.mullick@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org, marcin.slusarz@gmail.com
Subject: Re: [PATCH] Fixing section mismatch warning .
Date: Fri, 05 Sep 2008 19:18:40 +0200	[thread overview]
Message-ID: <1220635120.11202.18.camel@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <b9df5fa10809020843h2d264062g894b5a719dca9091@mail.gmail.com>

On Tue, 2008-09-02 at 21:43 +0600, Rakib Mullick wrote:
> LD      kernel/built-in.o
> WARNING: kernel/built-in.o(.text+0x326): Section mismatch in reference
> from the function init_hrtick() to the variable
> ..cpuinit.data:hotplug_hrtick_nb.8
> The function init_hrtick() references
> the variable __cpuinitdata hotplug_hrtick_nb.8.
> This is often because init_hrtick lacks a __cpuinitdata
> annotation or the annotation of hotplug_hrtick_nb.8 is wrong.
> 
>  This patch fixes the above warning.
>  Thanks.
> 
> Signed-off-by: Md.Rakib H. Mullick (rakib.mullick@gmail.com)
> 
> --- linux-2.6.27-rc5.orig/kernel/sched.c	2008-08-31 17:07:03.000000000 +0600
> +++ linux-2.6.27-rc5/kernel/sched.c	2008-09-01 22:23:30.000000000 +0600
> @@ -1087,7 +1087,7 @@ hotplug_hrtick(struct notifier_block *nf
>  	return NOTIFY_DONE;
>  }
> 
> -static void init_hrtick(void)
> +static __init void init_hrtick(void)
>  {
>  	hotcpu_notifier(hotplug_hrtick, 0);
>  }

then, shouldn't it be __cpuinit ?

BTW - would've been nice to see sched mentioned in the topic.


      reply	other threads:[~2008-09-05 17:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-02 15:43 Rakib Mullick
2008-09-05 17:18 ` Peter Zijlstra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1220635120.11202.18.camel@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcin.slusarz@gmail.com \
    --cc=mingo@elte.hu \
    --cc=rakib.mullick@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome