mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] Fixing section mismatch warning .
@ 2008-09-02 15:43 Rakib Mullick
  2008-09-05 17:18 ` Peter Zijlstra
  0 siblings, 1 reply; 2+ messages in thread
From: Rakib Mullick @ 2008-09-02 15:43 UTC (permalink / raw)
  To: Ingo Molnar; +Cc: linux-kernel, marcin.slusarz

   LD      kernel/built-in.o
WARNING: kernel/built-in.o(.text+0x326): Section mismatch in reference
from the function init_hrtick() to the variable
.cpuinit.data:hotplug_hrtick_nb.8
The function init_hrtick() references
the variable __cpuinitdata hotplug_hrtick_nb.8.
This is often because init_hrtick lacks a __cpuinitdata
annotation or the annotation of hotplug_hrtick_nb.8 is wrong.

 This patch fixes the above warning.
 Thanks.

Signed-off-by: Md.Rakib H. Mullick (rakib.mullick@gmail.com)

--- linux-2.6.27-rc5.orig/kernel/sched.c	2008-08-31 17:07:03.000000000 +0600
+++ linux-2.6.27-rc5/kernel/sched.c	2008-09-01 22:23:30.000000000 +0600
@@ -1087,7 +1087,7 @@ hotplug_hrtick(struct notifier_block *nf
 	return NOTIFY_DONE;
 }

-static void init_hrtick(void)
+static __init void init_hrtick(void)
 {
 	hotcpu_notifier(hotplug_hrtick, 0);
 }

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fixing section mismatch warning .
  2008-09-02 15:43 [PATCH] Fixing section mismatch warning Rakib Mullick
@ 2008-09-05 17:18 ` Peter Zijlstra
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Zijlstra @ 2008-09-05 17:18 UTC (permalink / raw)
  To: Rakib Mullick; +Cc: Ingo Molnar, linux-kernel, marcin.slusarz

On Tue, 2008-09-02 at 21:43 +0600, Rakib Mullick wrote:
> LD      kernel/built-in.o
> WARNING: kernel/built-in.o(.text+0x326): Section mismatch in reference
> from the function init_hrtick() to the variable
> ..cpuinit.data:hotplug_hrtick_nb.8
> The function init_hrtick() references
> the variable __cpuinitdata hotplug_hrtick_nb.8.
> This is often because init_hrtick lacks a __cpuinitdata
> annotation or the annotation of hotplug_hrtick_nb.8 is wrong.
> 
>  This patch fixes the above warning.
>  Thanks.
> 
> Signed-off-by: Md.Rakib H. Mullick (rakib.mullick@gmail.com)
> 
> --- linux-2.6.27-rc5.orig/kernel/sched.c	2008-08-31 17:07:03.000000000 +0600
> +++ linux-2.6.27-rc5/kernel/sched.c	2008-09-01 22:23:30.000000000 +0600
> @@ -1087,7 +1087,7 @@ hotplug_hrtick(struct notifier_block *nf
>  	return NOTIFY_DONE;
>  }
> 
> -static void init_hrtick(void)
> +static __init void init_hrtick(void)
>  {
>  	hotcpu_notifier(hotplug_hrtick, 0);
>  }

then, shouldn't it be __cpuinit ?

BTW - would've been nice to see sched mentioned in the topic.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-09-05 17:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-09-02 15:43 [PATCH] Fixing section mismatch warning Rakib Mullick
2008-09-05 17:18 ` Peter Zijlstra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome