* [PATCH] tty: tty_io.c shadows sparse fix
@ 2008-09-26 19:48 Jason Wessel
0 siblings, 0 replies; only message in thread
From: Jason Wessel @ 2008-09-26 19:48 UTC (permalink / raw)
To: alan; +Cc: linux-kernel
Fix the problem reported by sparse:
drivers/char/tty_io.c:1413:17: warning: symbol 'buf' shadows an earlier one
drivers/char/tty_io.c:1379:20: originally declared here
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
---
drivers/char/tty_io.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c
index daeb8f7..a155002 100644
--- a/drivers/char/tty_io.c
+++ b/drivers/char/tty_io.c
@@ -1410,19 +1410,19 @@ static inline ssize_t do_tty_write(
/* write_buf/write_cnt is protected by the atomic_write_lock mutex */
if (tty->write_cnt < chunk) {
- unsigned char *buf;
+ unsigned char *buf_chunk;
if (chunk < 1024)
chunk = 1024;
- buf = kmalloc(chunk, GFP_KERNEL);
- if (!buf) {
+ buf_chunk = kmalloc(chunk, GFP_KERNEL);
+ if (!buf_chunk) {
ret = -ENOMEM;
goto out;
}
kfree(tty->write_buf);
tty->write_cnt = chunk;
- tty->write_buf = buf;
+ tty->write_buf = buf_chunk;
}
/* Do the write .. */
--
1.6.0.90.g436ed.dirty
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-09-26 19:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-09-26 19:48 [PATCH] tty: tty_io.c shadows sparse fix Jason Wessel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®