From: Peter Zijlstra <peterz@infradead.org>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: miaox@cn.fujitsu.com, Ingo Molnar <mingo@elte.hu>,
Linux-Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched: fix the wrong mask_len
Date: Fri, 17 Oct 2008 12:33:04 +0200 [thread overview]
Message-ID: <1224239584.28131.85.camel@twins> (raw)
In-Reply-To: <20081017192505.E242.KOSAKI.MOTOHIRO@jp.fujitsu.com>
On Fri, 2008-10-17 at 19:25 +0900, KOSAKI Motohiro wrote:
> > If the NR_CPUS isn't a multiple of 32, we get a truncated string of sched
> > domains by catting /proc/schedstat. This is caused by the wrong mask_len.
> >
> > This patch fix it.
> >
> > Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
> >
> > ---
> > kernel/sched_stats.h | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/kernel/sched_stats.h b/kernel/sched_stats.h
> > index 8385d43..81365b3 100644
> > --- a/kernel/sched_stats.h
> > +++ b/kernel/sched_stats.h
> > @@ -9,7 +9,7 @@
> > static int show_schedstat(struct seq_file *seq, void *v)
> > {
> > int cpu;
> > - int mask_len = NR_CPUS/32 * 9;
> > + int mask_len = (NR_CPUS/32 + 1) * 9;
> > char *mask_str = kmalloc(mask_len, GFP_KERNEL);
> >
>
> DIV_ROUND_UP() is better?
Agreed
next prev parent reply other threads:[~2008-10-17 10:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-17 10:17 Miao Xie
2008-10-17 10:25 ` KOSAKI Motohiro
2008-10-17 10:33 ` Peter Zijlstra [this message]
2008-10-17 10:58 ` Peter Zijlstra
2008-10-17 11:01 ` KOSAKI Motohiro
2008-10-17 10:26 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1224239584.28131.85.camel@twins \
--to=peterz@infradead.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®