From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: kosaki.motohiro@jp.fujitsu.com, miaox@cn.fujitsu.com,
Ingo Molnar <mingo@elte.hu>,
Linux-Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched: fix the wrong mask_len
Date: Fri, 17 Oct 2008 20:01:59 +0900 (JST) [thread overview]
Message-ID: <20081017200120.7D56.KOSAKI.MOTOHIRO@jp.fujitsu.com> (raw)
In-Reply-To: <1224241099.28131.88.camel@twins>
> ---
> Subject: sched: fix the wrong mask_len
> From: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Date: Fri Oct 17 12:55:57 CEST 2008
>
> If the NR_CPUS isn't a multiple of 32, we get a truncated string of sched
> domains by catting /proc/schedstat. This is caused by the wrong mask_len.
>
> Reported-by: Miao Xie <miaox@cn.fujitsu.com>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> ---
> kernel/sched_stats.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6/kernel/sched_stats.h
> ===================================================================
> --- linux-2.6.orig/kernel/sched_stats.h
> +++ linux-2.6/kernel/sched_stats.h
> @@ -9,7 +9,7 @@
> static int show_schedstat(struct seq_file *seq, void *v)
> {
> int cpu;
> - int mask_len = NR_CPUS/32 * 9;
> + int mask_len = DIV_ROUND_UP(NR_CPUS, 32) * 9;
> char *mask_str = kmalloc(mask_len, GFP_KERNEL);
>
> if (mask_str == NULL)
Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
next prev parent reply other threads:[~2008-10-17 11:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-17 10:17 Miao Xie
2008-10-17 10:25 ` KOSAKI Motohiro
2008-10-17 10:33 ` Peter Zijlstra
2008-10-17 10:58 ` Peter Zijlstra
2008-10-17 11:01 ` KOSAKI Motohiro [this message]
2008-10-17 10:26 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081017200120.7D56.KOSAKI.MOTOHIRO@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®