* [patchlet] sched: minor fast-path overhead reduction
@ 2008-10-17 13:33 Mike Galbraith
2008-10-17 13:36 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Mike Galbraith @ 2008-10-17 13:33 UTC (permalink / raw)
To: Peter Zijlstra; +Cc: Ingo Molnar, LKML
Greetings,
103638d added a bit of avoidable overhead to the fast-path.
Use sysctl_sched_min_granularity instead of sched_slice() to restrict buddy wakeups.
Signed-off-by: Mike Galbraith <efault@gmx.de>
diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
index 18fd171..6708493 100644
--- a/kernel/sched_fair.c
+++ b/kernel/sched_fair.c
@@ -747,7 +747,7 @@ pick_next(struct cfs_rq *cfs_rq, struct sched_entity *se)
struct rq *rq = rq_of(cfs_rq);
u64 pair_slice = rq->clock - cfs_rq->pair_start;
- if (!cfs_rq->next || pair_slice > sched_slice(cfs_rq, cfs_rq->next)) {
+ if (!cfs_rq->next || pair_slice > sysctl_sched_min_granularity) {
cfs_rq->pair_start = rq->clock;
return se;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patchlet] sched: minor fast-path overhead reduction
2008-10-17 13:33 [patchlet] sched: minor fast-path overhead reduction Mike Galbraith
@ 2008-10-17 13:36 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-10-17 13:36 UTC (permalink / raw)
To: Mike Galbraith; +Cc: Peter Zijlstra, LKML
* Mike Galbraith <efault@gmx.de> wrote:
> Greetings,
>
> 103638d added a bit of avoidable overhead to the fast-path.
>
> Use sysctl_sched_min_granularity instead of sched_slice() to restrict buddy wakeups.
>
> Signed-off-by: Mike Galbraith <efault@gmx.de>
applied to tip/sched/urgent, thanks Mike!
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-17 13:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-17 13:33 [patchlet] sched: minor fast-path overhead reduction Mike Galbraith
2008-10-17 13:36 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®