From: Johannes Berg <johannes@sipsolutions.net>
To: Joe Perches <joe@perches.com>
Cc: Harvey Harrison <harvey.harrison@gmail.com>,
David Miller <davem@davemloft.net>,
anders@anduras.de, netdev@vger.kernel.org,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCHv3] printk: add %pM format specifier for MAC addresses
Date: Tue, 28 Oct 2008 09:06:26 +0100 [thread overview]
Message-ID: <1225181186.3796.71.camel@johannes.berg> (raw)
In-Reply-To: <1225153359.5269.112.camel@localhost>
[-- Attachment #1: Type: text/plain, Size: 826 bytes --]
On Mon, 2008-10-27 at 17:22 -0700, Joe Perches wrote:
> On Mon, 2008-10-27 at 17:05 -0700, Harvey Harrison wrote:
> > On Mon, 2008-10-27 at 16:55 -0700, David Miller wrote:
> > > I'm ok with the '#' modifier but remind me again what's wrong with
> > > using plain %p4 and %p6?
> > Nothing at all, just wanted to know what color bikeshed you wanted.
> > I'll go with %p4 %p6.
>
> Just an FYI for v6 addresses:
>
> There are a few uses of ipv6 address as "%08X%08X%08X%08X"
> Pavel Emelyanov tried to isolate them with a suggested patch:
>
> http://www.mail-archive.com/netdev@vger.kernel.org/msg51655.html
>
> These addresses are not shown in network order, but are
> printed backwards in host order. Oops. Apparently it's
> too late to fix them.
So that code we don't touch here at all.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2008-10-28 8:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1224892008.3919.27.camel@johannes.berg>
[not found] ` <49035AF0.6040700@anduras.de>
[not found] ` <1225008096.3478.3.camel@johannes.berg>
[not found] ` <20081026.010329.11475786.davem@davemloft.net>
[not found] ` <1225009308.3478.22.camel@johannes.berg>
[not found] ` <1225009822.3478.30.camel@johannes.berg>
[not found] ` <1225047674.10060.10.camel@brick>
[not found] ` <1225049591.3746.0.camel@johannes.berg>
[not found] ` <1225049929.10060.11.camel@brick>
[not found] ` <1225050015.3746.2.camel@johannes.berg>
[not found] ` <1225060789.10060.13.camel@brick>
2008-10-27 0:31 ` [RFC PATCHv2] printk: add the %pM, %p4, %p6 format specifiers Harvey Harrison
2008-10-27 1:21 ` Frans Pop
2008-10-27 2:08 ` H. Peter Anvin
2008-10-27 6:59 ` Johannes Berg
2008-10-27 16:28 ` Harvey Harrison
2008-10-27 19:38 ` David Miller
2008-10-27 19:47 ` Johannes Berg
2008-10-27 19:59 ` [RFC PATCHv3] printk: add %pM format specifier for MAC addresses Harvey Harrison
2008-10-27 21:55 ` Joe Perches
2008-10-27 22:46 ` David Miller
2008-10-27 22:47 ` David Miller
2008-10-27 23:14 ` Harvey Harrison
2008-10-27 23:31 ` Alexey Dobriyan
2008-10-27 23:48 ` Joe Perches
2008-10-28 8:04 ` Johannes Berg
2008-10-27 23:55 ` David Miller
2008-10-28 0:05 ` Harvey Harrison
2008-10-28 0:22 ` Joe Perches
2008-10-28 8:06 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225181186.3796.71.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=akpm@linux-foundation.org \
--cc=anders@anduras.de \
--cc=davem@davemloft.net \
--cc=harvey.harrison@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®