From: Frans Pop <elendil@planet.nl>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: johannes@sipsolutions.net, davem@davemloft.net,
anders@anduras.de, netdev@vger.kernel.org,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCHv2] printk: add the %pM, %p4, %p6 format specifiers
Date: Mon, 27 Oct 2008 02:21:06 +0100 [thread overview]
Message-ID: <200810270221.08675.elendil@planet.nl> (raw)
In-Reply-To: <1225067465.5672.1.camel@brick>
Harvey Harrison wrote:
> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> index a013bbc..eec3879 100644
> --- a/lib/vsprintf.c
> +++ b/lib/vsprintf.c
> @@ -592,6 +644,12 @@ static char *resource_string(char *buf, char *end,
> struct resource *res, int fie
> * - 'S' For symbolic direct pointers
> * - 'R' For a struct resource pointer, it prints the range of
> * addresses (not the name nor the flags)
> + * - 'M' For a 6-byte MAC address, it prints the address in the
> + * usual colon-separated hex notation
> + * - '4' For a 4-byte IPv4 address, it prints the address in the
> + * usual colon-separated hex notation
> + * - 'M' For a 16-byte IPv6 address, it prints the address in colon separated
> + * big-endian 16 bit hex notation
Shouldn't that last one be '6' instead of 'M'?
next prev parent reply other threads:[~2008-10-27 1:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1224892008.3919.27.camel@johannes.berg>
[not found] ` <49035AF0.6040700@anduras.de>
[not found] ` <1225008096.3478.3.camel@johannes.berg>
[not found] ` <20081026.010329.11475786.davem@davemloft.net>
[not found] ` <1225009308.3478.22.camel@johannes.berg>
[not found] ` <1225009822.3478.30.camel@johannes.berg>
[not found] ` <1225047674.10060.10.camel@brick>
[not found] ` <1225049591.3746.0.camel@johannes.berg>
[not found] ` <1225049929.10060.11.camel@brick>
[not found] ` <1225050015.3746.2.camel@johannes.berg>
[not found] ` <1225060789.10060.13.camel@brick>
2008-10-27 0:31 ` Harvey Harrison
2008-10-27 1:21 ` Frans Pop [this message]
2008-10-27 2:08 ` H. Peter Anvin
2008-10-27 6:59 ` Johannes Berg
2008-10-27 16:28 ` Harvey Harrison
2008-10-27 19:38 ` David Miller
2008-10-27 19:47 ` Johannes Berg
2008-10-27 19:59 ` [RFC PATCHv3] printk: add %pM format specifier for MAC addresses Harvey Harrison
2008-10-27 21:55 ` Joe Perches
2008-10-27 22:46 ` David Miller
2008-10-27 22:47 ` David Miller
2008-10-27 23:14 ` Harvey Harrison
2008-10-27 23:31 ` Alexey Dobriyan
2008-10-27 23:48 ` Joe Perches
2008-10-28 8:04 ` Johannes Berg
2008-10-27 23:55 ` David Miller
2008-10-28 0:05 ` Harvey Harrison
2008-10-28 0:22 ` Joe Perches
2008-10-28 8:06 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810270221.08675.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=akpm@linux-foundation.org \
--cc=anders@anduras.de \
--cc=davem@davemloft.net \
--cc=harvey.harrison@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome