* [PATCH] autodetect_raid: add missing __init marking
@ 2008-11-21 4:05 Mike Frysinger
2008-12-27 6:40 ` Mike Frysinger
0 siblings, 1 reply; 2+ messages in thread
From: Mike Frysinger @ 2008-11-21 4:05 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
The function autodetect_raid is only used by __init functions, and it refers
to __initdata, so it needs __init markings. Fixes this error:
The function autodetect_raid() references
the variable __initdata raid_noautodetect.
This is often because autodetect_raid lacks a __initdata
annotation or the annotation of raid_noautodetect is wrong.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
init/do_mounts_md.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/init/do_mounts_md.c b/init/do_mounts_md.c
index d6da5cd..ff95e31 100644
--- a/init/do_mounts_md.c
+++ b/init/do_mounts_md.c
@@ -271,7 +271,7 @@ static int __init raid_setup(char *str)
__setup("raid=", raid_setup);
__setup("md=", md_setup);
-static void autodetect_raid(void)
+static void __init autodetect_raid(void)
{
int fd;
--
1.6.0.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] autodetect_raid: add missing __init marking
2008-11-21 4:05 [PATCH] autodetect_raid: add missing __init marking Mike Frysinger
@ 2008-12-27 6:40 ` Mike Frysinger
0 siblings, 0 replies; 2+ messages in thread
From: Mike Frysinger @ 2008-12-27 6:40 UTC (permalink / raw)
To: Andrew Morton; +Cc: lkml
On Thu, Nov 20, 2008 at 23:05, Mike Frysinger wrote:
> The function autodetect_raid is only used by __init functions, and it refers
> to __initdata, so it needs __init markings. Fixes this error:
> The function autodetect_raid() references
> the variable __initdata raid_noautodetect.
> This is often because autodetect_raid lacks a __initdata
> annotation or the annotation of raid_noautodetect is wrong.
Andrew: could you add this ?
-mike
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-27 6:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-11-21 4:05 [PATCH] autodetect_raid: add missing __init marking Mike Frysinger
2008-12-27 6:40 ` Mike Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®