From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Ken Chen <kenchen@google.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [patch] make wake-affine a sysctl variable
Date: Fri, 05 Dec 2008 09:51:57 +0100 [thread overview]
Message-ID: <1228467117.18899.30.camel@twins> (raw)
In-Reply-To: <b040c32a0812050044g309eafb7h5b2eb29d9d8840c2@mail.gmail.com>
On Fri, 2008-12-05 at 00:44 -0800, Ken Chen wrote:
> On Thu, Dec 4, 2008 at 11:49 PM, Peter Zijlstra wrote:
> > This patch looks like utter rubbish, sorry.
>
> Yeah, I think turning off wake-affine completely is a lot cleaner and
> is a preferred solution. I proposed sysctl variable earlier so that
> it can give people a knob to adjust and is more flexible.
Hehe, right, I guess I deserved that.
What I meant was, sysctl_sched_features is a horrid user interface. If
you want to expose it as a sysctl - which I still don't think we want -
create a new one that goes on/off, like sysctl_sched_wake_affine.
Anyway, is this thing you're seeing the same as pgbench, if not, care to
cook a benchmark? I really think the 1:N waker issue is solvable (not
saying its easy though).
prev parent reply other threads:[~2008-12-05 8:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-05 7:37 Ken Chen
2008-12-05 7:49 ` Peter Zijlstra
2008-12-05 8:44 ` Ken Chen
2008-12-05 8:51 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228467117.18899.30.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=kenchen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®