From: Ken Chen <kenchen@google.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ingo Molnar <mingo@elte.hu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [patch] make wake-affine a sysctl variable
Date: Fri, 5 Dec 2008 00:44:52 -0800 [thread overview]
Message-ID: <b040c32a0812050044g309eafb7h5b2eb29d9d8840c2@mail.gmail.com> (raw)
In-Reply-To: <1228463394.18899.17.camel@twins>
On Thu, Dec 4, 2008 at 11:49 PM, Peter Zijlstra wrote:
> This patch looks like utter rubbish, sorry.
Yeah, I think turning off wake-affine completely is a lot cleaner and
is a preferred solution. I proposed sysctl variable earlier so that
it can give people a knob to adjust and is more flexible.
diff --git a/kernel/sched_features.h b/kernel/sched_features.h
index da5d93b..c712958 100644
--- a/kernel/sched_features.h
+++ b/kernel/sched_features.h
@@ -2,7 +2,7 @@ SCHED_FEAT(NEW_FAIR_SLEEPERS, 1)
SCHED_FEAT(NORMALIZED_SLEEPER, 1)
SCHED_FEAT(WAKEUP_PREEMPT, 1)
SCHED_FEAT(START_DEBIT, 1)
-SCHED_FEAT(AFFINE_WAKEUPS, 1)
+SCHED_FEAT(AFFINE_WAKEUPS, 0)
SCHED_FEAT(CACHE_HOT_BUDDY, 1)
SCHED_FEAT(SYNC_WAKEUPS, 1)
SCHED_FEAT(HRTICK, 0)
next prev parent reply other threads:[~2008-12-05 8:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-05 7:37 Ken Chen
2008-12-05 7:49 ` Peter Zijlstra
2008-12-05 8:44 ` Ken Chen [this message]
2008-12-05 8:51 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b040c32a0812050044g309eafb7h5b2eb29d9d8840c2@mail.gmail.com \
--to=kenchen@google.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®