mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] x86: irqinit_64.c declare init_ISA_irqs before they get used
@ 2008-12-15 17:42 Jaswinder Singh
  2008-12-15 19:53 ` Yinghai Lu
  0 siblings, 1 reply; 3+ messages in thread
From: Jaswinder Singh @ 2008-12-15 17:42 UTC (permalink / raw)
  To: Ingo Molnar, LKML

Signed-off-by: Jaswinder Singh <jaswinder@infradead.org>

Included asm/arch_hooks.h for init_ISA_irqs
---
 arch/x86/kernel/irqinit_64.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/irqinit_64.c b/arch/x86/kernel/irqinit_64.c
index b33d02f..d1f9663 100644
--- a/arch/x86/kernel/irqinit_64.c
+++ b/arch/x86/kernel/irqinit_64.c
@@ -21,6 +21,7 @@
 #include <asm/delay.h>
 #include <asm/desc.h>
 #include <asm/apic.h>
+#include <asm/arch_hooks.h>
 #include <asm/i8259.h>
 
 /*
-- 
1.5.5.1




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] x86: irqinit_64.c declare init_ISA_irqs before they get used
  2008-12-15 17:42 [PATCH] x86: irqinit_64.c declare init_ISA_irqs before they get used Jaswinder Singh
@ 2008-12-15 19:53 ` Yinghai Lu
  2008-12-16  3:49   ` Jaswinder Singh
  0 siblings, 1 reply; 3+ messages in thread
From: Yinghai Lu @ 2008-12-15 19:53 UTC (permalink / raw)
  To: Jaswinder Singh; +Cc: Ingo Molnar, LKML

On Mon, Dec 15, 2008 at 9:42 AM, Jaswinder Singh
<jaswinder@infradead.org> wrote:
> Signed-off-by: Jaswinder Singh <jaswinder@infradead.org>
>
> Included asm/arch_hooks.h for init_ISA_irqs
> ---
>  arch/x86/kernel/irqinit_64.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/kernel/irqinit_64.c b/arch/x86/kernel/irqinit_64.c
> index b33d02f..d1f9663 100644
> --- a/arch/x86/kernel/irqinit_64.c
> +++ b/arch/x86/kernel/irqinit_64.c
> @@ -21,6 +21,7 @@
>  #include <asm/delay.h>
>  #include <asm/desc.h>
>  #include <asm/apic.h>
> +#include <asm/arch_hooks.h>
>  #include <asm/i8259.h>


not needed.

could change that to static for 64bit.

YH

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] x86: irqinit_64.c declare init_ISA_irqs before they get used
  2008-12-15 19:53 ` Yinghai Lu
@ 2008-12-16  3:49   ` Jaswinder Singh
  0 siblings, 0 replies; 3+ messages in thread
From: Jaswinder Singh @ 2008-12-16  3:49 UTC (permalink / raw)
  To: Yinghai Lu; +Cc: Ingo Molnar, LKML

On Mon, 2008-12-15 at 11:53 -0800, Yinghai Lu wrote:

> 
> not needed.
> 
> could change that to static for 64bit.
> 

Thanks for your suggestion.

I also CC '[PATCH] x86: irqinit_64.c init_ISA_irqs should be static' to
you :-)

Thank you,

Jaswinder Singh.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-12-16  3:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-12-15 17:42 [PATCH] x86: irqinit_64.c declare init_ISA_irqs before they get used Jaswinder Singh
2008-12-15 19:53 ` Yinghai Lu
2008-12-16  3:49   ` Jaswinder Singh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®