From: Eric Paris <eparis@redhat.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, hch@infradead.org,
akpm@linux-foundation.org
Subject: Re: [PATCH 1/3] filesystem notification: create fs/notify to contain all fs notification
Date: Mon, 15 Dec 2008 20:37:36 -0500 [thread overview]
Message-ID: <1229391456.23523.10.camel@localhost.localdomain> (raw)
In-Reply-To: <20081216095546.06C7.KOSAKI.MOTOHIRO@jp.fujitsu.com>
On Tue, 2008-12-16 at 10:02 +0900, KOSAKI Motohiro wrote:
> Hi
>
> > Creating a generic filesystem notification interface, fsnotify, which will be
> > used by inotify, dnotify, and eventually fanotify is really starting to
> > clutter the fs directory. This patch simply moves inotify and dnotify into
> > fs/notify/inotify and fs/notify/dnotify respectively.
> >
> > Signed-off-by: Eric Paris <eparis@redhat.com>
> > ---
> >
> > fs/Kconfig | 39 --
> > fs/Makefile | 5
> > fs/dnotify.c | 194 --------
> > fs/inotify.c | 913 --------------------------------------
> > fs/inotify_user.c | 778 --------------------------------
> > fs/notify/Kconfig | 2
> > fs/notify/Makefile | 2
> > fs/notify/dnotify/Kconfig | 10
> > fs/notify/dnotify/Makefile | 1
> > fs/notify/dnotify/dnotify.c | 194 ++++++++
> > fs/notify/inotify/Kconfig | 27 +
> > fs/notify/inotify/Makefile | 2
> > fs/notify/inotify/inotify.c | 913 ++++++++++++++++++++++++++++++++++++++
> > fs/notify/inotify/inotify_user.c | 778 ++++++++++++++++++++++++++++++++
> > 14 files changed, 1931 insertions(+), 1927 deletions(-)
> > delete mode 100644 fs/dnotify.c
> > delete mode 100644 fs/inotify.c
> > delete mode 100644 fs/inotify_user.c
> > create mode 100644 fs/notify/Kconfig
> > create mode 100644 fs/notify/Makefile
> > create mode 100644 fs/notify/dnotify/Kconfig
> > create mode 100644 fs/notify/dnotify/Makefile
> > create mode 100644 fs/notify/dnotify/dnotify.c
> > create mode 100644 fs/notify/inotify/Kconfig
> > create mode 100644 fs/notify/inotify/Makefile
> > create mode 100644 fs/notify/inotify/inotify.c
> > create mode 100644 fs/notify/inotify/inotify_user.c
>
> 1) this mail only contain Kconfig and Makefile changing patch.
> iow, this patch doesn't contain file moving information.
> iow, patch statics and actual patch are different.
> 2) your latter patch doesn't depend on this patch.
> this patch doesn't have justification.
> I recommend to separate this patch.
It is there, it is just in the git -M rename diff output rather than
"normal" diff. See the sections like:
diff --git a/fs/dnotify.c b/fs/notify/dnotify/dnotify.c
similarity index 100%
rename from fs/dnotify.c
rename to fs/notify/dnotify/dnotify.c
This type of patch can be applied directly to your git tree and makes
review trivial.....
If people who will put this into a subsystem would prefer the long diff
I'll gladly resend.
I'll agree it isn't required but the other 2 aren't going to apply
without it, and it does clean up fs. I'd much rather get this early
than in the middle somewhere since others are also looking at changing
this subsystem at the same time.... It can be dropped it others
agree....
next prev parent reply other threads:[~2008-12-16 1:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-15 16:44 [PATCH 0/3] send notification events about exec Eric Paris
2008-12-15 16:44 ` [PATCH 1/3] filesystem notification: create fs/notify to contain all fs notification Eric Paris
2008-12-16 1:02 ` KOSAKI Motohiro
2008-12-16 1:37 ` Eric Paris [this message]
2008-12-16 1:46 ` KOSAKI Motohiro
2008-12-15 16:44 ` [PATCH 2/3] fsnotify: sys_execve and sys_uselib do not call into fsnotify Eric Paris
2008-12-16 1:02 ` KOSAKI Motohiro
2008-12-15 16:44 ` [PATCH 3/3] fsnotify: use the new open-exec hook for inotify and dnotify Eric Paris
2008-12-16 1:12 ` KOSAKI Motohiro
2008-12-16 1:52 ` Eric Paris
2008-12-16 2:01 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1229391456.23523.10.camel@localhost.localdomain \
--to=eparis@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®