From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Eric Paris <eparis@redhat.com>
Cc: kosaki.motohiro@jp.fujitsu.com, linux-kernel@vger.kernel.org,
hch@infradead.org, akpm@linux-foundation.org
Subject: Re: [PATCH 1/3] filesystem notification: create fs/notify to contain all fs notification
Date: Tue, 16 Dec 2008 10:02:09 +0900 (JST) [thread overview]
Message-ID: <20081216095546.06C7.KOSAKI.MOTOHIRO@jp.fujitsu.com> (raw)
In-Reply-To: <20081215164409.2018.26639.stgit@paris.rdu.redhat.com>
Hi
> Creating a generic filesystem notification interface, fsnotify, which will be
> used by inotify, dnotify, and eventually fanotify is really starting to
> clutter the fs directory. This patch simply moves inotify and dnotify into
> fs/notify/inotify and fs/notify/dnotify respectively.
>
> Signed-off-by: Eric Paris <eparis@redhat.com>
> ---
>
> fs/Kconfig | 39 --
> fs/Makefile | 5
> fs/dnotify.c | 194 --------
> fs/inotify.c | 913 --------------------------------------
> fs/inotify_user.c | 778 --------------------------------
> fs/notify/Kconfig | 2
> fs/notify/Makefile | 2
> fs/notify/dnotify/Kconfig | 10
> fs/notify/dnotify/Makefile | 1
> fs/notify/dnotify/dnotify.c | 194 ++++++++
> fs/notify/inotify/Kconfig | 27 +
> fs/notify/inotify/Makefile | 2
> fs/notify/inotify/inotify.c | 913 ++++++++++++++++++++++++++++++++++++++
> fs/notify/inotify/inotify_user.c | 778 ++++++++++++++++++++++++++++++++
> 14 files changed, 1931 insertions(+), 1927 deletions(-)
> delete mode 100644 fs/dnotify.c
> delete mode 100644 fs/inotify.c
> delete mode 100644 fs/inotify_user.c
> create mode 100644 fs/notify/Kconfig
> create mode 100644 fs/notify/Makefile
> create mode 100644 fs/notify/dnotify/Kconfig
> create mode 100644 fs/notify/dnotify/Makefile
> create mode 100644 fs/notify/dnotify/dnotify.c
> create mode 100644 fs/notify/inotify/Kconfig
> create mode 100644 fs/notify/inotify/Makefile
> create mode 100644 fs/notify/inotify/inotify.c
> create mode 100644 fs/notify/inotify/inotify_user.c
1) this mail only contain Kconfig and Makefile changing patch.
iow, this patch doesn't contain file moving information.
iow, patch statics and actual patch are different.
2) your latter patch doesn't depend on this patch.
this patch doesn't have justification.
I recommend to separate this patch.
next prev parent reply other threads:[~2008-12-16 1:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-15 16:44 [PATCH 0/3] send notification events about exec Eric Paris
2008-12-15 16:44 ` [PATCH 1/3] filesystem notification: create fs/notify to contain all fs notification Eric Paris
2008-12-16 1:02 ` KOSAKI Motohiro [this message]
2008-12-16 1:37 ` Eric Paris
2008-12-16 1:46 ` KOSAKI Motohiro
2008-12-15 16:44 ` [PATCH 2/3] fsnotify: sys_execve and sys_uselib do not call into fsnotify Eric Paris
2008-12-16 1:02 ` KOSAKI Motohiro
2008-12-15 16:44 ` [PATCH 3/3] fsnotify: use the new open-exec hook for inotify and dnotify Eric Paris
2008-12-16 1:12 ` KOSAKI Motohiro
2008-12-16 1:52 ` Eric Paris
2008-12-16 2:01 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081216095546.06C7.KOSAKI.MOTOHIRO@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=eparis@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®