* [PATCH] x86: common.c boot_cpu_stack and boot_exception_stacks should be static
@ 2008-12-19 17:03 Jaswinder Singh
2008-12-19 22:16 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Jaswinder Singh @ 2008-12-19 17:03 UTC (permalink / raw)
To: Ingo Molnar, x86 maintainers, LKML
Impact: cleanup, avoid sparse warnings, reduce kernel size a bit
Fixes these sparse warnings:
arch/x86/kernel/cpu/common.c:869:6: warning: symbol 'boot_cpu_stack' was not declared. Should it be static?
arch/x86/kernel/cpu/common.c:910:6: warning: symbol 'boot_exception_stacks' was not declared. Should it be static?
Signed-off-by: Jaswinder Singh <jaswinder@infradead.org>
---
arch/x86/kernel/cpu/common.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index cd7437c..e57a725 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -866,7 +866,7 @@ EXPORT_SYMBOL(_cpu_pda);
struct desc_ptr idt_descr = { 256 * 16 - 1, (unsigned long) idt_table };
-char boot_cpu_stack[IRQSTACKSIZE] __page_aligned_bss;
+static char boot_cpu_stack[IRQSTACKSIZE] __page_aligned_bss;
void __cpuinit pda_init(int cpu)
{
@@ -907,8 +907,8 @@ void __cpuinit pda_init(int cpu)
}
}
-char boot_exception_stacks[(N_EXCEPTION_STACKS - 1) * EXCEPTION_STKSZ +
- DEBUG_STKSZ] __page_aligned_bss;
+static char boot_exception_stacks[(N_EXCEPTION_STACKS - 1) * EXCEPTION_STKSZ +
+ DEBUG_STKSZ] __page_aligned_bss;
extern asmlinkage void ignore_sysret(void);
--
1.5.5.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] x86: common.c boot_cpu_stack and boot_exception_stacks should be static
2008-12-19 17:03 [PATCH] x86: common.c boot_cpu_stack and boot_exception_stacks should be static Jaswinder Singh
@ 2008-12-19 22:16 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-12-19 22:16 UTC (permalink / raw)
To: Jaswinder Singh; +Cc: x86 maintainers, LKML
* Jaswinder Singh <jaswinder@infradead.org> wrote:
> Impact: cleanup, avoid sparse warnings, reduce kernel size a bit
>
> Fixes these sparse warnings:
> arch/x86/kernel/cpu/common.c:869:6: warning: symbol 'boot_cpu_stack' was not declared. Should it be static?
> arch/x86/kernel/cpu/common.c:910:6: warning: symbol 'boot_exception_stacks' was not declared. Should it be static?
>
> Signed-off-by: Jaswinder Singh <jaswinder@infradead.org>
> ---
> arch/x86/kernel/cpu/common.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
applied to tip/x86/cleanups, thanks!
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-19 22:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-12-19 17:03 [PATCH] x86: common.c boot_cpu_stack and boot_exception_stacks should be static Jaswinder Singh
2008-12-19 22:16 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®