From: Jiri Slaby <jirislaby@gmail.com>
To: mchehab@infradead.org
Cc: video4linux-list@redhat.com, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, Jiri Slaby <jirislaby@gmail.com>
Subject: [PATCH 1/2] V4L: usbvideo, fix module ref count check
Date: Mon, 22 Dec 2008 13:14:55 +0100 [thread overview]
Message-ID: <1229948096-5254-1-git-send-email-jirislaby@gmail.com> (raw)
In-Reply-To: <1228767934-14193-1-git-send-email-jirislaby@gmail.com>
-ENORESPONSE, CCing akpm
--
usbvideo_ClientIncModCount may return value < 0 in the case of error, not > 0.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
---
drivers/media/video/usbvideo/usbvideo.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/usbvideo/usbvideo.c b/drivers/media/video/usbvideo/usbvideo.c
index 7c575bb..6ace064 100644
--- a/drivers/media/video/usbvideo/usbvideo.c
+++ b/drivers/media/video/usbvideo/usbvideo.c
@@ -1123,7 +1123,7 @@ static int usbvideo_v4l_open(struct inode *inode, struct file *file)
if (uvd->debug > 1)
dev_info(&uvd->dev->dev, "%s($%p)\n", __func__, dev);
- if (0 < usbvideo_ClientIncModCount(uvd))
+ if (usbvideo_ClientIncModCount(uvd) < 0)
return -ENODEV;
mutex_lock(&uvd->lock);
--
1.6.0.5
next prev parent reply other threads:[~2008-12-22 12:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-08 20:25 [PATCH 1/1] " Jiri Slaby
2008-12-22 12:14 ` Jiri Slaby [this message]
2008-12-22 12:14 ` [PATCH 2/2] MAINTAINERS: mark linux-uvc-devel as subscribers only Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1229948096-5254-1-git-send-email-jirislaby@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®