From: Andy Walls <awalls@radix.net>
To: Ingo Molnar <mingo@elte.hu>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
linux-dvb-maintainer@linuxtv.org, video4linux-list@redhat.com,
linux-kernel@vger.kernel.org,
Patrick Boettcher <patrick.boettcher@desy.de>
Subject: Re: [v4l-dvb-maintainer] [patch] fix warning in drivers/media/dvb/dvb-usb/af9005-fe.c
Date: Sat, 27 Dec 2008 15:24:34 -0500 [thread overview]
Message-ID: <1230409474.3121.27.camel@palomino.walls.org> (raw)
In-Reply-To: <20081227120020.GA8660@elte.hu>
On Sat, 2008-12-27 at 13:00 +0100, Ingo Molnar wrote:
> * Ingo Molnar <mingo@elte.hu> wrote:
>
> Btw., there's a handful of warning fixes i carry in tip/warnings/* topic
> branches - you can find them in tip/master via:
>
> http://people.redhat.com/mingo/tip.git/README
>
> the ones affecting drivers/media/ are:
>
> f3e67e2: fix warning in drivers/media/video/usbvision/usbvision-i2c.c
> 491af31: fix warning in drivers/media/video/cx18/cx18-mailbox.c
Mauro & Ingo,
If the cx18 warning message is fixed in the following diff, that I
culled from a LKML posting by Ingo on 29 Nov, then Ingo's patch for
cx18-mailbox.c should be overcome by events in the latest v4l-dvb repo.
"req" is now always assigned a value before it is ever used. (Sorry, I
didn't want to pull the > 100 MB git/tip down over my dialup connection
to verify this was the item in question).
diff --git a/drivers/media/video/cx18/cx18-mailbox.c b/drivers/media/video/cx18/cx18-mailbox.c
index acff7df..5c847be 100644
--- a/drivers/media/video/cx18/cx18-mailbox.c
+++ b/drivers/media/video/cx18/cx18-mailbox.c
@@ -184,7 +184,7 @@ long cx18_mb_ack(struct cx18 *cx, const struct cx18_mailbox *mb)
static int cx18_api_call(struct cx18 *cx, u32 cmd, int args, u32 data[])
{
const struct cx18_api_info *info = find_api_info(cmd);
- u32 state = 0, irq = 0, req, oldreq, err;
+ u32 state = 0, irq = 0, uninitialized_var(req), oldreq, err;
struct cx18_mailbox __iomem *mb;
wait_queue_head_t *waitq;
int timeout = 100;
> 728342a: fix warnings in drivers/media/dvb/ttusb-dec/ttusb_dec.c
> 4dda565: fix warning in drivers/media/dvb/frontends/drx397xD.c
> a2e4f4a: fix warning in drivers/media/common/tuners/mxl5007t.c
> 8317adf: fix warning in drivers/media/dvb/dvb-usb/anysee.c
>
> this one appears to be GCC warning about a real bug:
>
> 8317adf: fix warning in drivers/media/dvb/dvb-usb/anysee.c
>
> the others are fixes for false positives - i reviewed the affected code
> paths and each commit log includes the analysis about why it is a false
> positive.
> Please have a look and git-cherry-pick the above commits if they are still
> relevant to your tree and if you agree with them. Thanks,
>
> Ingo
Regards,
Andy
next prev parent reply other threads:[~2008-12-27 20:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-24 14:12 [GIT PATCHES for 2.6.28] V4L/DVB fixes Mauro Carvalho Chehab
2008-12-25 8:19 ` Ingo Molnar
2008-12-25 10:30 ` Ingo Molnar
2008-12-26 13:08 ` Mauro Carvalho Chehab
2008-12-26 15:38 ` Luca Olivetti
2008-12-25 23:24 ` Mauro Carvalho Chehab
2008-12-26 9:02 ` Ingo Molnar
2008-12-26 13:13 ` Mauro Carvalho Chehab
2008-12-26 13:24 ` [GIT PATCHES for 2.6.28] V4L/DVB fixes, crash in af9005_usb_module_init() Ingo Molnar
2008-12-26 13:45 ` Mauro Carvalho Chehab
2008-12-27 12:00 ` [patch] fix warning in drivers/media/dvb/dvb-usb/af9005-fe.c Ingo Molnar
2008-12-27 20:24 ` Andy Walls [this message]
2008-12-30 19:49 ` [v4l-dvb-maintainer] " Mauro Carvalho Chehab
2008-12-27 16:40 ` [GIT PATCHES for 2.6.28] V4L/DVB fixes, crash in af9005_usb_module_init() Ingo Molnar
2008-12-27 17:11 ` Cyrill Gorcunov
2008-12-27 17:19 ` Cyrill Gorcunov
2008-12-27 18:01 ` Cyrill Gorcunov
2008-12-30 19:33 ` Mauro Carvalho Chehab
2008-12-30 19:40 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1230409474.3121.27.camel@palomino.walls.org \
--to=awalls@radix.net \
--cc=linux-dvb-maintainer@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=mingo@elte.hu \
--cc=patrick.boettcher@desy.de \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®