Re: [v4l-dvb-maintainer] [patch] fix warning in drivers/media/dvb/dvb-usb/af9005-fe.c

[Mauro Carvalho Chehab <mchehab@redhat.com>]

On Sat, 27 Dec 2008 15:24:34 -0500
Andy Walls <awalls@radix.net> wrote:

> On Sat, 2008-12-27 at 13:00 +0100, Ingo Molnar wrote:
> > * Ingo Molnar <mingo@elte.hu> wrote:
> > 
> > Btw., there's a handful of warning fixes i carry in tip/warnings/* topic 
> > branches - you can find them in tip/master via:
> > 
> >   http://people.redhat.com/mingo/tip.git/README
> > 
> > the ones affecting drivers/media/ are:
> > 
> >   f3e67e2: fix warning in drivers/media/video/usbvision/usbvision-i2c.c
> >   491af31: fix warning in drivers/media/video/cx18/cx18-mailbox.c
> 
> Mauro & Ingo,
> 
> If the cx18 warning message is fixed in the following diff, that I
> culled from a LKML posting by Ingo on 29 Nov, then Ingo's patch for
> cx18-mailbox.c should be overcome by events in the latest v4l-dvb repo.
> "req" is now always assigned a value before it is ever used.  (Sorry, I
> didn't want to pull the > 100 MB git/tip down over my dialup connection
> to verify this was the item in question).
> 
> 
> diff --git a/drivers/media/video/cx18/cx18-mailbox.c b/drivers/media/video/cx18/cx18-mailbox.c
> index acff7df..5c847be 100644
> --- a/drivers/media/video/cx18/cx18-mailbox.c
> +++ b/drivers/media/video/cx18/cx18-mailbox.c
> @@ -184,7 +184,7 @@ long cx18_mb_ack(struct cx18 *cx, const struct cx18_mailbox *mb)
>  static int cx18_api_call(struct cx18 *cx, u32 cmd, int args, u32 data[])
>  {
>  	const struct cx18_api_info *info = find_api_info(cmd);
> -	u32 state = 0, irq = 0, req, oldreq, err;
> +	u32 state = 0, irq = 0, uninitialized_var(req), oldreq, err;
>  	struct cx18_mailbox __iomem *mb;
>  	wait_queue_head_t *waitq;
>  	int timeout = 100;

This patch also didn't apply.

I also couldn't reproduce this warning here [1].

[1] gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-44)

Ingo,

I've added almost 600 patches on my merge tree, several of them that I've
merged recently from driver maintainers. I've already fixed all warnings I got
here with allmodconfig.

Could you please double check if the patches you've added on your tree are still needed?

Thanks,
Mauro.