From: Mike Frysinger <vapier@gentoo.org>
To: Sam Ravnborg <sam@ravnborg.org>, linux-kernel@vger.kernel.org
Subject: [PATCH] kbuild: warn about headers using __[us]{8,16,32,64} types w/out linux/types.h
Date: Mon, 29 Dec 2008 07:18:47 -0500 [thread overview]
Message-ID: <1230553127-953-1-git-send-email-vapier@gentoo.org> (raw)
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
| 20 ++++++++++++++++++++
1 files changed, 20 insertions(+), 0 deletions(-)
--git a/scripts/headers_check.pl b/scripts/headers_check.pl
index bdd9fb6..5036319 100644
--- a/scripts/headers_check.pl
+++ b/scripts/headers_check.pl
@@ -37,6 +37,7 @@ foreach my $file (@files) {
check_include();
check_prototypes();
check_config();
+ check_sizetypes();
}
close FH;
}
@@ -72,3 +73,22 @@ sub check_config
printf STDERR "$filename:$lineno: leaks CONFIG_$1 to userspace where it is not valid\n";
}
}
+
+my $linux_types;
+sub check_sizetypes
+{
+ if ($lineno == 1) {
+ $linux_types = 0;
+ } elsif ($linux_types) {
+ return;
+ }
+ if ($line =~ m/^\s*#\s*include\s+<linux\/types.h>/) {
+ $linux_types = 1;
+ return;
+ }
+ if ($line =~ m/__[us](8|16|32|64)\b/) {
+ printf STDERR "$filename:$lineno: found __[us]{8,16,32,64} type w/out #include <linux/types.h>\n";
+ # Warn until headers are all fixed
+ #$ret = 1;
+ }
+}
--
1.6.0.6
next reply other threads:[~2008-12-29 12:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-29 12:18 Mike Frysinger [this message]
2008-12-29 13:24 ` Sam Ravnborg
2008-12-29 20:27 ` Mike Frysinger
2008-12-30 10:43 ` Sam Ravnborg
2008-12-30 11:50 ` Mike Frysinger
2013-10-08 19:03 ` [PATCH] kbuild: warn about headers using __[us]{8, 16, 32, 64} " Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1230553127-953-1-git-send-email-vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®