Re: [PATCH] kbuild: warn about headers using __[us]{8, 16, 32, 64} types w/out linux/types.h

[Geert Uytterhoeven <geert@linux-m68k.org>]

On Tue, 30 Dec 2008, Sam Ravnborg wrote:
> Subject: [PATCH] kbuild: add checks for include of linux/types in userspace headers

> If we see __[us](8|16|32|64) then we must include <linux/types.h>

> +	if ($line =~ m/__[us](8|16|32|64)\b/) {
> +		printf STDERR "$filename:$lineno: " .
> +		              "found __[us]{8,16,32,64} type " .
> +		              "without #include <linux/types.h>\n";
> +		$linux_types = 2;
> +		# Warn until headers are all fixed
> +		#$ret = 1;
> +	}

FWIW, this also triggers on __[us]{8,16,32,64} in comments instead of in
actual code (just got caught ;-).

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds