* [PATCH 1/1] x86_64: fix RIP printout in early_idt_handler
@ 2009-01-03 23:27 Jiri Slaby
2009-01-04 9:20 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Slaby @ 2009-01-03 23:27 UTC (permalink / raw)
To: mingo; +Cc: linux-kernel, Jiri Slaby, Thomas Gleixner, H. Peter Anvin
Since errorcode is popped out, RIP is on the top of the stack.
Use real RIP value instead of wrong CS.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
---
arch/x86/kernel/head_64.S | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/head_64.S b/arch/x86/kernel/head_64.S
index 26cfdc1..0e275d4 100644
--- a/arch/x86/kernel/head_64.S
+++ b/arch/x86/kernel/head_64.S
@@ -305,7 +305,7 @@ ENTRY(early_idt_handler)
call dump_stack
#ifdef CONFIG_KALLSYMS
leaq early_idt_ripmsg(%rip),%rdi
- movq 8(%rsp),%rsi # get rip again
+ movq 0(%rsp),%rsi # get rip again
call __print_symbol
#endif
#endif /* EARLY_PRINTK */
--
1.6.0.6
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] x86_64: fix RIP printout in early_idt_handler
2009-01-03 23:27 [PATCH 1/1] x86_64: fix RIP printout in early_idt_handler Jiri Slaby
@ 2009-01-04 9:20 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2009-01-04 9:20 UTC (permalink / raw)
To: Jiri Slaby; +Cc: mingo, linux-kernel, Thomas Gleixner, H. Peter Anvin
* Jiri Slaby <jirislaby@gmail.com> wrote:
> Since errorcode is popped out, RIP is on the top of the stack.
> Use real RIP value instead of wrong CS.
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: H. Peter Anvin <hpa@zytor.com>
> ---
> arch/x86/kernel/head_64.S | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
good spotting - applied to tip/x86/urgent, thanks Jiri. I have also added
a -stable backport tag.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-04 9:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-01-03 23:27 [PATCH 1/1] x86_64: fix RIP printout in early_idt_handler Jiri Slaby
2009-01-04 9:20 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®