mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Robert Richter <robert.richter@amd.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
	oprofile-list <oprofile-list@lists.sourceforge.net>,
	Robert Richter <robert.richter@amd.com>
Subject: [PATCH 17/18] oprofile: rename add_sample() in cpu_buffer.c
Date: Wed, 7 Jan 2009 23:17:34 +0100	[thread overview]
Message-ID: <1231366655-17837-18-git-send-email-robert.richter@amd.com> (raw)
In-Reply-To: <1231366655-17837-1-git-send-email-robert.richter@amd.com>

Rename the fucntion to op_add_sample() since there is a collision with
another one with the same name in buffer_sync.c.

Signed-off-by: Robert Richter <robert.richter@amd.com>
---
 drivers/oprofile/cpu_buffer.c |   22 +++++++++++-----------
 1 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/oprofile/cpu_buffer.c b/drivers/oprofile/cpu_buffer.c
index 92bf8c0..ac79f66 100644
--- a/drivers/oprofile/cpu_buffer.c
+++ b/drivers/oprofile/cpu_buffer.c
@@ -188,8 +188,8 @@ unsigned long op_cpu_buffer_entries(int cpu)
 }
 
 static inline int
-add_sample(struct oprofile_cpu_buffer *cpu_buf,
-	   unsigned long pc, unsigned long event)
+op_add_sample(struct oprofile_cpu_buffer *cpu_buf,
+	      unsigned long pc, unsigned long event)
 {
 	struct op_entry entry;
 	int ret;
@@ -207,7 +207,7 @@ add_sample(struct oprofile_cpu_buffer *cpu_buf,
 static inline int
 add_code(struct oprofile_cpu_buffer *buffer, unsigned long value)
 {
-	return add_sample(buffer, ESCAPE_CODE, value);
+	return op_add_sample(buffer, ESCAPE_CODE, value);
 }
 
 /* This must be safe from any context. It's safe writing here
@@ -249,7 +249,7 @@ static int log_sample(struct oprofile_cpu_buffer *cpu_buf, unsigned long pc,
 			goto fail;
 	}
 
-	if (add_sample(cpu_buf, pc, event))
+	if (op_add_sample(cpu_buf, pc, event))
 		goto fail;
 
 	return 1;
@@ -337,14 +337,14 @@ void oprofile_add_ibs_sample(struct pt_regs * const regs,
 	}
 
 	fail = fail || add_code(cpu_buf, ibs_code);
-	fail = fail || add_sample(cpu_buf, ibs_sample[0], ibs_sample[1]);
-	fail = fail || add_sample(cpu_buf, ibs_sample[2], ibs_sample[3]);
-	fail = fail || add_sample(cpu_buf, ibs_sample[4], ibs_sample[5]);
+	fail = fail || op_add_sample(cpu_buf, ibs_sample[0], ibs_sample[1]);
+	fail = fail || op_add_sample(cpu_buf, ibs_sample[2], ibs_sample[3]);
+	fail = fail || op_add_sample(cpu_buf, ibs_sample[4], ibs_sample[5]);
 
 	if (ibs_code == IBS_OP_BEGIN) {
-		fail = fail || add_sample(cpu_buf, ibs_sample[6], ibs_sample[7]);
-		fail = fail || add_sample(cpu_buf, ibs_sample[8], ibs_sample[9]);
-		fail = fail || add_sample(cpu_buf, ibs_sample[10], ibs_sample[11]);
+		fail = fail || op_add_sample(cpu_buf, ibs_sample[6], ibs_sample[7]);
+		fail = fail || op_add_sample(cpu_buf, ibs_sample[8], ibs_sample[9]);
+		fail = fail || op_add_sample(cpu_buf, ibs_sample[10], ibs_sample[11]);
 	}
 
 	if (!fail)
@@ -376,7 +376,7 @@ void oprofile_add_trace(unsigned long pc)
 	if (pc == ESCAPE_CODE)
 		goto fail;
 
-	if (add_sample(cpu_buf, pc, 0))
+	if (op_add_sample(cpu_buf, pc, 0))
 		goto fail;
 
 	return;
-- 
1.6.0.1



  parent reply	other threads:[~2009-01-07 22:29 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-07 22:17 [0/18] oprofile: fixes and cleanup patches Robert Richter
2009-01-07 22:17 ` [PATCH 01/18] oprofile: rename kernel-wide identifiers Robert Richter
2009-01-13 17:53   ` Maynard Johnson
2009-01-14 14:21     ` Robert Richter
2009-01-07 22:17 ` [PATCH 02/18] oprofile: rename cpu buffer functions Robert Richter
2009-01-13 18:02   ` Maynard Johnson
2009-01-07 22:17 ` [PATCH 03/18] oprofile: remove ring buffer inline functions in cpu_buffer.h Robert Richter
2009-01-07 22:17 ` [PATCH 04/18] x86/oprofile: fix pci_dev use count for AMD northbridge devices Robert Richter
2009-01-07 22:17 ` [PATCH 05/18] oprofile: reordering some code in cpu_buffer.c Robert Richter
2009-01-07 22:17 ` [PATCH 06/18] oprofile: add inline function __oprofile_add_ext_sample() Robert Richter
2009-01-07 22:17 ` [PATCH 07/18] oprofile: simplify add_sample() Robert Richter
2009-01-07 22:17 ` [PATCH 08/18] oprofile: simplify sync_buffer() Robert Richter
2009-01-07 22:17 ` [PATCH 09/18] oprofile: simplify oprofile_begin_trace() Robert Richter
2009-01-07 22:17 ` [PATCH 10/18] oprofile: simplify add_sample() in cpu_buffer.c Robert Richter
2009-01-07 22:17 ` [PATCH 11/18] oprofile: simplify add_ibs_begin() Robert Richter
2009-01-07 22:17 ` [PATCH 12/18] oprofile: remove unused components in struct oprofile_cpu_buffer Robert Richter
2009-01-07 22:17 ` [PATCH 13/18] oprofile: remove unused ibs macro Robert Richter
2009-01-07 22:17 ` [PATCH 14/18] oprofile: remove backtrace code for ibs Robert Richter
2009-01-07 22:17 ` [PATCH 15/18] oprofile: making add_sample_entry() inline Robert Richter
2009-01-07 22:17 ` [PATCH 16/18] oprofile: rename variable ibs_allowed to has_ibs in op_model_amd.c Robert Richter
2009-01-07 22:17 ` Robert Richter [this message]
2009-01-07 22:17 ` [PATCH 18/18] oprofile: rename variables in add_ibs_begin() Robert Richter
2009-01-08 12:10 ` [0/18] oprofile: fixes and cleanup patches Ingo Molnar
2009-01-13 19:51 ` Maynard Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1231366655-17837-18-git-send-email-robert.richter@amd.com \
    --to=robert.richter@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oprofile-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome